[Olsr-dev] Improving SPF with binary heaps

[Diogo Gonçalves]

Hi,

I looked at the branch and the code looks fine.

Was intentional the single @param comment at heap_is_node_added function?
Apart from that the code looks great.

Can I help you with something? I still have been trying to run olsrd on
CORE but without success, when I run my olsrd on core I will send you the
performance report.

Best regards.



2015-10-04 12:42 GMT-03:00 Henning Rogge <(spam-protected)>:

> Hi,
>
> I just added the heap code to the OLSRv2 repository (in a branch
> called "heap") and did a few basic tests...
>
> I have not (at the moment) added the heap code to the "src/common"
> directory because I still have to rework it for generic "key"
> variables.
>
> Feel free to have a look at the branch.
>
> Henning
>
> On Fri, Sep 18, 2015 at 11:23 AM, Henning Rogge <(spam-protected)> wrote:
> > We had a fix for olsrd some time ago which was important for Core...
> >
> > because Core forgets to set a good broadcast address.
> >
> > Merge the latest olsr master branch into your binary heap branch and try
> again.
> >
> > Henning
> >
> > On Thu, Sep 17, 2015 at 11:21 PM, Diogo Gonçalves
> > <(spam-protected)> wrote:
> >> Hi,
> >>
> >> Sorry for my long time offline, I had some problems at home that
> disturbed
> >> me.
> >>
> >> I finish my new patch [1] following the plain, if i did something wrong
> >> about the plain, tell me and i'll fix it.
> >>
> >> Henning suggested me to use CORE to test my code, I installed the
> emulator
> >> but I haven't found a way to configure CORE to run my olsrd. Is there a
> >> reference to learn more about olsrd on CORE?
> >>
> >> Again, sorry for my time out. I'm available to work on this project and
> I
> >> want to do this.
> >>
> >> Best regards
> >>
> >>
> >>
> >> [1] https://github.com/diogomg/olsrd-binary-heap
> >>
> >> 2015-08-21 1:40 GMT-03:00 Henning Rogge <(spam-protected)>:
> >>>
> >>> On Fri, Aug 21, 2015 at 2:30 AM, Diogo Gonçalves
> >>> <(spam-protected)> wrote:
> >>>>
> >>>> Hi,
> >>>>
> >>>> I'm finishing my patch, I'll send it to you soon.
> >>>>
> >>>> For now, I just have some issues about how to measure the performance
> of
> >>>> the priority queues in olsrd. I'm using olsr switch to test my code
> and I
> >>>> did not find a good way to scale my network and measure the
> performance. I
> >>>> have some results outside the olsrd(see attachments) using
> kcachegrind and
> >>>> other tools to do this and now I'm trying to measure the performance
> into
> >>>> the olsrd too.
> >>>>
> >>>> Is olsr switch the best way to do this?
> >>>
> >>>
> >>> No, it is definitely not.
> >>>
> >>> I would go with an emulator like CORE (from the NRL) or maybe setup a
> >>> bunch of VMs on my own.
> >>>
> >>> Henning
> >>>
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20151005/fc591f06/attachment.html>