[Olsr-dev] [PATCH] plugins: fix build with musl

[Daniel Golle]

On Fri, May 15, 2015 at 10:07:46PM +0200, Ferry Huberts wrote:
> >>Don't ever push anything without review into our repository again please.
> >
> >Well, you told me to. And the patch broke Android build, and I tried to
> >fix it and caused stuff to be broken for minutes.

> That wasn't me.

True. And you blamed the right person for having done so.

> Well, reverse positions for a while then.
> You are the maintainer and now I start pushing in patches without you even
> having seen them. And then I make a mess of it. You would be ticked off as
> well.

The issue of build not working with musl is known for a while, I was hoping
people would notice
https://github.com/openwrt-routing/packages/pull/85

As that didn't happen (and as an upstream project maintainer you are surely
not obliged to look at what all downstream projects are doing, so no blame
here at all), I went forward and posted the patch on the mailing list.
I got a reply from someone I found in the commit log, which was enough for
me to know that it wasn't a random troll but actually someone actively
involved in the project.

Maybe gerrit (which goes nicely with Jenkins) or patchwork is what you want?

At least in the current way, stuff gets force-reviewed quite quickly after
being pushed...


Cheers


Daniel