[Olsr-dev] [PATCH] plugins: fix build with musl

[Ferry Huberts]

On 15/05/15 22:02, Daniel Golle wrote:
> On Fri, May 15, 2015 at 09:55:25PM +0200, Ferry Huberts wrote:
>> A grand entry.
>> 4 patches were needed, of which at least 1 wasn't even compiled before being
>> pushed.
>
> I did compile test locally before pushing.
> (I didn't test all possible build targets and toolchains, obviously)
>
>> Don't ever push anything without review into our repository again please.
>
> Well, you told me to. And the patch broke Android build, and I tried to
> fix it and caused stuff to be broken for minutes.
>

That wasn't me.

If someone tells you that your patch broke stuff, I'd imagine you would 
be careful to test a follow-up patch fixing the breakage before pushing. 
I would.

> I hope I won't ever have to touch it again.
>

Well, reverse positions for a while then.
You are the maintainer and now I start pushing in patches without you 
even having seen them. And then I make a mess of it. You would be ticked 
off as well.


-- 
Ferry Huberts