[Olsr-dev] changing 'linux' macro to __linux__ or __gnu_linux__

[Hans-Christoph Steiner]

On 02/03/2012 03:40 AM, Ferry Huberts wrote:
> 
> 
> On 03-02-12 09:12, Henning Rogge wrote:
>> On 02/02/2012 05:23 PM, Ferry Huberts wrote:
>>>
>>>
>>> On 01-02-12 20:56, Hans-Christoph Steiner wrote:
>>>
>>>> If people are amenable, I'll post a patch. This isn't so much to fix a
>>>> specific issue now, but rather to prevent issues from arising in the
>>>> future.
>>>
>>> NACK
>>>
>>> it fixes nothing.
>>> fix issues when they arise.
>> The "fix issues when they arise" was one of the reason I started doing a
>> clean rewrite of lots of basic code in OLSRd. If you don't clean up the
>> code and refactor it from time to time, you end up with working code
>> that is very hard to maintain.
>>
>> So yes, I would be interested in a sane solution for the platform
>> dependent macros. I hope we can get rid of most of them, but maybe a few
>> of them will have to stay.
>>
> 
> ok, let me explain my nack...
> 
> I'm a bit afraid of doing this since olsrd is targeted for many
> platforms, and that is hard to get right (ask henning..). it appears
> that it is working now and touching stuff that changes that is risky and
> needs to done very carefully.
> 
> so it's mainly this 'fear' provoking me to that nack.
> 
> however...
> since our project is only using linux, we don't mind the change ;-)

I understand that fear well, since I've experienced the downsides a lot,
as well as getting things working smoothly.  To give some background on
me, since I probably came out of nowhere for most of you, I'm one of the
main developers of Pd aka Pure Data, which runs on GNU/Linux, Mac OS X,
Windows, Maemo, Android, iOS, BSD, etc. as well as embedded into Java,
Python, and video games like EA Games Spore.  These days I'm
porting/building lots of things to Android, like LUKS, gnupg, ffmpeg,
etc. So basically, I'm asking lots of questions to get a feel for how
things work here, and figuring out I best can plug in.

I've had a long standing interest in mesh, and now I'm working as part
of the Commotion project, on contract, to make olsrd really easy to use
on Android, and hopefully also on GNU/Linux, Mac OS X, and maybe
Windows.  So that's why I can suddenly spend lots of time on this :-D

So I figure since I'm paid, I'd do some necessary grunt work, like
working on the build system.  I find most people don't care much about
build systems, as long as they work for themselves.  But there are also
many people who are very particular about build systems.  If the olsrd
community is like the first group, I'm happy to dive in and write a
standardized GNU make build system that'll work on all the existing
platforms and be easy to package for things like Debian, Fedora, etc.
If its like the latter, I'm happy to submit patches for the bugs I've find.

.hc