[Olsr-dev] changing 'linux' macro to __linux__ or __gnu_linux__

[Ferry Huberts]

On 03-02-12 09:12, Henning Rogge wrote:
> On 02/02/2012 05:23 PM, Ferry Huberts wrote:
>>
>>
>> On 01-02-12 20:56, Hans-Christoph Steiner wrote:
>>
>>> If people are amenable, I'll post a patch. This isn't so much to fix a
>>> specific issue now, but rather to prevent issues from arising in the
>>> future.
>>
>> NACK
>>
>> it fixes nothing.
>> fix issues when they arise.
> The "fix issues when they arise" was one of the reason I started doing a
> clean rewrite of lots of basic code in OLSRd. If you don't clean up the
> code and refactor it from time to time, you end up with working code
> that is very hard to maintain.
>
> So yes, I would be interested in a sane solution for the platform
> dependent macros. I hope we can get rid of most of them, but maybe a few
> of them will have to stay.
>

ok, let me explain my nack...

I'm a bit afraid of doing this since olsrd is targeted for many 
platforms, and that is hard to get right (ask henning..). it appears 
that it is working now and touching stuff that changes that is risky and 
needs to done very carefully.

so it's mainly this 'fear' provoking me to that nack.

however...
since our project is only using linux, we don't mind the change ;-)



-- 
Ferry Huberts