[OLSR-users] invalid Link type between sym_NEIGH ?

[Frédéric DELAUNAY]

I tested OOLSR, from Hipercom and it works like Unik OLSR, or it's maybe 
Unik who works like OOLSR ? :-P
So in the RFC:

          7       6       5       4       3       2       1       0
      +-------+-------+-------+-------+-------+-------+-------+-------+
      |   0   |   0   |   0   |   0   | Neighbor Type |   Link Type   |
      +-------+-------+-------+-------+-------+-------+-------+-------+

with:

18.5.  Link Types
          UNSPEC_LINK           = 0
          ASYM_LINK             = 1
          SYM_LINK              = 2
          LOST_LINK             = 3
18.6.  Neighbor Types
          NOT_NEIGH             = 0
          SYM_NEIGH             = 1
          MPR_NEIGH             = 2

So in our case
4 means SYM_LINK with no NOT_NEIGH, that's strange... when the definition is:
     -    NOT_NEIGH - indicating that the nodes are either no longer or
          have not yet become symmetric neighbors.

In the example of Daffys Neko all link between nodes is Symetric ? right ? so a SYM_NEIGH will be better
     -    SYM_NEIGH - indicating that the neighbors have at least one
          symmetrical link with this node.
and then SYM_LINK + SYM_NEIGH = 0110 => 6 (Symmetric Link)
So I don't know if what I said will help but it seems that there is a mistake.

Have a nice Week end
- Fred



Frédéric DELAUNAY a écrit :

> for Information here's the code from ethereal:
> >                    /*------------------------------Dissect Link 
> Type---------------------------------- */
> >                    switch(tvb_get_guint8(tvb, offset))    {
> >                        case 0:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Unspecified Link");
> >                            break;
> >                        case 1:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Asymmetric Link");
> >                            break;
> >                        case 6:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Symmetric Link");
> >                            break;
> >                        case 3:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Lost Link");
> >                            break;
> >                        case 10:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: MPR Link");
> >                            break;
> >                        case 5:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Pending");
> >                            break;
> >                        default:
> >                            proto_tree_add_uint_format(olsr_tree, 
> hf_olsr_link_type, tvb, offset, 1, tvb_get_guint8(tvb, offset), "Link 
> Type: Invalid");
> >                            break;
> >                    }/* end switch Link Type */
> >
> >                    /*----------------------Dissect Link Message 
> Size--------------------------*/
>
> So the 04 should be 06 ? Isn't it ?
> Fred
>
> Andreas Tønnesen a écrit :
>
>>>>> What is the actual value of the link type field in question?
>>>>>
>>>>> - Andreas
>>>>>       
>>>>
>>> The actual value is 04. invalid for ethereal.
>>> Fred
>>>   
>>
>>
>> Strange... I'll have a look at it later on.
>>
>> - Andreas
>>
>>
>> ---------
>> Andreas Tønnesen
>> http://www.olsr.org
>> _______________________________________________
>> olsr-users mailing list
>> (spam-protected)
>> https://www.olsr.org/mailman/listinfo/olsr-users
>>
>>  
>>
> _______________________________________________
> olsr-users mailing list
> (spam-protected)
> https://www.olsr.org/mailman/listinfo/olsr-users
>