[Olsr-dev] [PATCH v1 0/9] Also consider link state

[Henning Rogge]

On Thu, Feb 11, 2016 at 2:53 PM, Bastian Bittorf <(spam-protected)> wrote:
> * Henning Rogge <(spam-protected)> [11.02.2016 14:33]:
>> > up  : state != DOWN &&  IFF_UP
>> > down: state == DOWN || !IFF_UP  (same as !up)
>> >
>> > note what happens when state == UNKNOWN: fallback to what we have now
>>
>> I am not sure we even get an "undefined" state on these routers... as
>> far as I understand Bastian we get a WRONG state.
>
> no, the assumption that state != DOWN && IFF_UP
> seems OK to me. the only problem i see for switches is
> that DOWN is never reached (but this is ok for OLSR)

If you think that the patch is okay both for the embedded hardware
(and for "sane" computers) I think we should apply it.

It makes things better for normal hardware and it doesn't get worse
for the embedded one.

Henning