[Olsr-dev] jsoninfo ipv6only flag / OpenWrt

[Ferry Huberts]

On 24/10/14 10:22, cholin wrote:
> Thanks! Will there be a minor bugfix release or should I add these

That is up to Henning.
I see no real need (not already anyway)

> patches to the openwrt routing feed?

just point the feed at the correct git commit

>
> Regards
> Nico
>
> Am 24.10.2014 um 09:42 schrieb Ferry Huberts:
>> Committed.
>>
>> I've improved the commit messages a bit though ;-)
>>
>>
>> I seriously doubt that OpenWRT compiles in C89 mode.
>> We use 'bool' all over the place so more would go wrong...
>>
>> Besides, C89? Really?
>> That is so ancient that even Henning and I don't remember its limitations!
>>
>> On 23/10/14 20:15, cholin wrote:
>>> You can use my git repository on github for cherry-picking if you want:
>>>
>>>     https://github.com/cholin/olsrd/tree/release-0.6.7
>>>
>>> Regards
>>> Nico
>>>
>>> Am 23.10.2014 um 20:04 schrieb Henning Rogge:
>>>> On Thu, Oct 23, 2014 at 7:45 PM, cholin <(spam-protected)> wrote:
>>>>> No the type in the olsrd plugin itself for jsoninfo_ipv6_only in
>>>>> lib/jsoninfosrc/olsrc_plugin.c and olsrd_jsoninfo.h [1 2]. Take a look
>>>>> at the patch:
>>>>> https://github.com/cholin/packages/commit/25a47b48cbc7ef22f0343766606a1cb5be5114b2
>>>>>
>>>>
>>>> *looking through the plugin_utils code*
>>>>
>>>> okay, I backtracked this strange piece of code to a commit in 2007...
>>>> *sigh*
>>>>
>>>> the "set_plugin_boolean" parses boolean texts... but stores them in an
>>>> integer. -.-
>>>>
>>>> Which might trigger a compiler dependent problem, I am not sure.
>>>>
>>>> So your two patches are in fact right (even if the behavior is a bit
>>>> strange).
>>>>
>>>>
>>>> @Ferry: unless you see a problem with the two patches, Cholin should
>>>> commit them to our repository (in fact we might need to cherry pick
>>>> them for a bugfix branch too).
>>>>
>>>> Henning Rogge
>>>>
>>>
>>>
>>
>
>

-- 
Ferry Huberts