[Olsr-dev] 'debian/' folder should not be included in release tarballs!

[Hans-Christoph Steiner]

On 05/23/2013 01:03 AM, Teco Boot wrote:
> 
> Op 22 mei 2013, om 22:19 heeft Hans-Christoph Steiner <(spam-protected)> het volgende geschreven:
> 
>>
>>
>> On 05/22/2013 04:15 PM, Hans-Christoph Steiner wrote:
>>>
>>>
>>> On 05/22/2013 05:17 AM, Henning Rogge wrote:
>>>> On 05/22/2013 11:11 AM, Bernd Petrovitsch wrote:
>>>>> On Die, 2013-05-21 at 18:49 -0400, Hans-Christoph Steiner wrote:
>>>>> [....]
>>>>>> Any honestly, the best solution would be to just remove the debian/ folder
>>>>>> entirely.  It hasn't been updated since 2010.
>>>>>
>>>>> IIRC we added it on request of the Debian packager to help/ease/... the
>>>>> package maintenance and it was - of course - to be maintained by the
>>>>> Debian packager
>>>>
>>>> And it helps people who want to build a current debian file directly from our
>>>> repository.
>>>
>>> It doesn't really, because its out of date.  It really serves to confuse
>>> people who want to build the Debian package, but it looks like the right
>>> thing, but then won't work right.  We have made a lot of improvements on the
>>> Debian packaging since 2010, and olsrd has changed as well.
>>
>> I forgot to add: remove the debian/ folder and we add
>> README-Building-Debian-Package with this contents:
>>
>> To build the debian package, do this:
>>
>> 1. go to this page: http://packages.debian.org/source/sid/olsrd
>> 2. scroll down and download "olsrd_0.6.x.debian.tar.bz2
>> 3. extract tarball into your olsrd source folder (e.g. olsrd/)
>> 4. run "dpkg-buildpackage -uc -us"
>>
>> Then everyone wins!
> 
> Can I build latest greatest or my special version with this? Differences with debian .deb? If I have more homework, add it in this readme file?

The official packaging is more likely to fully and properly work than the old,
outdated packaging.  It should work with any recent version, except when there
are changes that conflict with the debian/rules build and the included patches
in debian/patches.

The old, outdated packaging might give you a .deb easier, but that is not the
same thing as a working .deb.

.hc


> 
> Teco
> 
>>
>> .hc
>>
>>
>>
>>>
>>>
>>>>> (as I'm more in the RedHat/Fedora packager world and put
>>>>> an olsrd.spec file for my own convenience in so that `rpm -ta
>>>>> olsrd-*.tar.gz` plain simply worked).
>>>>> I didn't and don't know enough on Debian package maintenance
>>>>> "procedures"/best practices to decide if these directories (and files)
>>>>> should be upstream or not.
>>>>> But if that is upstream, it should (read: must;-) come from the official
>>>>> downstream maintainer (if only that he may avoid to run his own repo -
>>>>> that may not be a inconvenience with `git` or `hg` but with `cvs` or
>>>>> `svn` it definitely is).
>>>>
>>>> I just looked through our tarballs, the /debian directory has been in the
>>>> tarballs for some time, did something changed on the debian side that makes it
>>>> a problem now?
>>>>
>>>> Henning Rogge
>>>
>>> I don't remember, but I do know that if the debian/ folder was not included in
>>> the release tarballs, 0.6.5.4 would already be in Debian as of today.
>>>
>>> .hc
>>>
>>
>> -- 
>> Olsr-dev mailing list
>> (spam-protected)
>> https://lists.olsr.org/mailman/listinfo/olsr-dev
>