[Olsr-dev] strange log message when received netlink error

[Henning Rogge]

Saverio is right, there might be other routes that trigger the error.

But removing the route that doesn't work from the OLSR database will
not really help, because it will be reintroduced by the next HNA
unless we build a "blacklist".

But we need to make sure that we handle the error code correctly so
that the rest of the routes get added.

Can we just accept the "-22" code as "work done"?

Henning Rogge

On Fri, Mar 29, 2013 at 8:59 AM, Ferry Huberts <(spam-protected)> wrote:
> I'd propose to just ignore /0 routes.
>
>
> On 29/03/13 03:24, Saverio Proto wrote:
>>>
>>> I would suggest we add some more filters in the HNA and TC input code.
>>> We must prevent malformed data to get into the OLSR database from
>>> other nodes. If a message contains such data, we should just drop it.>
>>> What do you think?
>>
>>
>> we can do that for sure. What about also handling the -22 netlink error
>> code ?
>>
>> you can do filters, but this does not make impossible to receive a
>> -22. The Kernel has always the last word !
>>
>> I will propose a patch
>>
>> I see avl_delete is called after olsr_delete_kernel_route just at line
>> 343 of process_routers.c correct ? there is no other part of the code
>> where the exit value of olsr_delete_kernel_route is evaluated ?
>>
>> thanks
>>
>> Saverio
>>
>
> --
> Ferry Huberts



-- 
We began as wanderers, and we are wanderers still. We have lingured
long enough on the shores of the cosmic ocean. We are ready at last to
set sail for the stars - Carl Sagan