[Olsr-dev] [PATCH v1 1/2] android: fix type punning warnings on IN6_IS_ADDR_V4MAPPED

[Hans-Christoph Steiner]

On 10/22/2012 12:50 PM, Henning Rogge wrote:
> On Mon, Oct 22, 2012 at 6:45 PM, Hans-Christoph Steiner
> <(spam-protected)> wrote:
>> If it was that simple, it would be done.  So far I've gotten no feedback on
>> the idea I outlined above.  Personally, I'd leave the code that's generating
>> this warning on Android as is until someone is actually setup to test things
>> using IPv6 on Android.  Commotion is currently all IPv4.  I've never used IPv6
>> and its not part of my current mandate for olsrd work, which I'm scrambling to
>> get done before the baby comes.
> 
> I must admit I still have trouble why the compiler has trouble with
> the old statement. The new one is a crazy thing, some special GCC
> extension.
> 
> If we replace it, I would suggest building an inline function that
> takes the "olsr_ip_addr" union and gives back a boolean. Much better
> than trying to fix a crazy preprocessor command.

Did you look at the Android header snippet I posted in this thread?  Once you
do, its clear why the compiler is throwing that warning.  The Android header
declares things differently and the GNU header.  The current olsrd code
follows the GNU definition.

.hc