[Olsr-dev] [PATCH v1 1/2] android: fix type punning warnings on IN6_IS_ADDR_V4MAPPED

Henning Rogge (spam-protected)
Mon Oct 22 18:50:16 CEST 2012


On Mon, Oct 22, 2012 at 6:45 PM, Hans-Christoph Steiner
<(spam-protected)> wrote:
> If it was that simple, it would be done.  So far I've gotten no feedback on
> the idea I outlined above.  Personally, I'd leave the code that's generating
> this warning on Android as is until someone is actually setup to test things
> using IPv6 on Android.  Commotion is currently all IPv4.  I've never used IPv6
> and its not part of my current mandate for olsrd work, which I'm scrambling to
> get done before the baby comes.

I must admit I still have trouble why the compiler has trouble with
the old statement. The new one is a crazy thing, some special GCC
extension.

If we replace it, I would suggest building an inline function that
takes the "olsr_ip_addr" union and gives back a boolean. Much better
than trying to fix a crazy preprocessor command.

Henning Rogge
-- 
Steven Hawkings about cosmic inflation: "An increase of billions of
billions of percent in a tiny fraction of a second. Of course, that
was before the present government."




More information about the Olsr-dev mailing list