[Olsr-dev] [PATCH v1 1/1] android: remove regex code and update API level

[Hans of Guardian]

On Oct 15, 2012, at 11:08 AM, Henning Rogge wrote:

> On Mon, Oct 15, 2012 at 5:03 PM, Hans of Guardian
> <(spam-protected)> wrote:
>> On Oct 15, 2012, at 11:00 AM, Henning Rogge wrote:
>>> On Mon, Oct 15, 2012 at 4:55 PM, Ferry Huberts <(spam-protected)> wrote:
>>>> Then please work with Henning in making the regex library a standalone
>>>> static library with it's own makefile.
>>> I will look into it and Hans can test it...
>> What benefit would this provide us?
> 
> Less warnings mean you recognize the one that is relevant more easily.
> 
> Its the same with valgrind problems... as soon as you have lots of
> "irrelevant ones", you easily miss the relevant ones.

A working build systems means you only rebuild the changed files, and those affected by it.  So you should only see those regex warnings once when you first compile.  So that's another approach to solving this issue.  Then you don't have to look through long build logs every time.

One thing that would help with this goal is to remove the builddata.c kludge.  These can be set using macros defined from the command line:

-DOLSRD_VERSION='"olsr.org -  0.6.3-git_a9c9b25-hash_7c4d4af59e8bb9c9dd2cb85eb4815c17  -"'

Plus gcc will do some of that for us if we using __DATE__ __TIME__
http://gcc.gnu.org/onlinedocs/cpp/Standard-Predefined-Macros.html

Then just make sure to do a "make clean" before making a final build.

.hc