[Olsr-dev] [quagga-dev 9393] [PATCH] quagga: Enable support for HSLS, OLSR and BATMAN protocols

[Vasilis Tsiligiannis]

Στις Σαβ 02 Ιουν 2012 10:33:35 David Lamparter έγραψε:
> On Fri, Jun 01, 2012 at 06:37:27PM +0300, Vasilis Tsiligiannis wrote:
> > diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c
> > index 15475e2..2624580 100644
> > --- a/zebra/rt_netlink.c
> > +++ b/zebra/rt_netlink.c
> > @@ -1623,6 +1623,9 @@ netlink_route_multipath (int cmd, struct prefix *p,
> > struct rib *rib,> 
> >                          addattr_l (&req.n, sizeof req, RTA_PREFSRC,
> >  				 
> >  				 &nexthop->src.ipv4, bytelen);
> > 
> > +		      if (rib->type == ZEBRA_ROUTE_OLSR)
> > +			req.r.rtm_scope = RT_SCOPE_LINK;
> > +
> 
> This kind of hardcoding semantics deep into the actual kernel backend is
> not workable.  We'll need some kind of proper handling here.

Correct. I know this is a dirty solution but I was not willing to propose a 
major change in the backend and probably a zclient protocol change. 
Suggestions on how to support handling of route scope issues in general would 
be welcome (any pointer to Joakim's patches?).

> Also, regarding olsrd integration, please look at
> http://git.nowhere.ws/?p=olsrd-zclient.git
> which, last time I checked, worked considerably better than the old
> plugin drifting around in the olsrd source.  If I find the time, I'll
> comment on the olsr-dev list too, I'm subscribed and have read half of
> the thread there.

Nice work. It is based on the old code and has some advantages, like the use 
of threads. But there are also some disadvantages that may be "blockers" for 
including in olsrd source.

Looking forward for your comments in olsr-dev! Maybe we can explore the 
possibility to integrate olsrd into quagga, like babeld did.

Cheers,
Vasilis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20120602/17c49f18/attachment.sig>