[Olsr-dev] gateway code

[Teco Boot]

Op 24 jul. 2012, om 11:42 heeft Henning Rogge het volgende geschreven:

> On 07/23/2012 02:16 PM, Ferry Huberts wrote:
>> Guys,
>> 
>> I'm reviewing the gateway code in olsrd to better understand it before
>> going to make modifications to it.
>> 
>> In the past I did some changes to that code in commits
>> 0f48c8a90f658928ac9df3ad439be1fab8343eba
>> ca155c05e39e2f2f576a361406ed20356806ed9c
>> f7097c6817954a92e33bdbf8b7e7c3ba12516808
>> 
>> 
>> While reviewing it now again, I'm not so sure anymore that these changes
>> I made are correct. Could you please review the afore mentioned changes?
>> 
>> Maybe I'll need to revert them, let's see what you think.
>> 
>> 
> 
> Has been some time since I even looked into this code... the code you removed were responsible for detecting a tunnel going down and up again (because I thought it is necessary to set the route into the tunnel again).
> 
> Its not really common, but could be potential annoying.
> 
> Can you test if what happens to the smart-gw if you take a tunnel down and up again from the shell?

Manual interference with unmanaged tunnels is a request for trouble. If there is a side effect on tunnel_down (e.g. removed routes), that is how it is designed.
Let's have a clean smart-gw.

Teco

> 
> Henning Rogge
> 
> -- 
> Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
> Kommunikation, Informationsverarbeitung und Ergonomie FKIE
> Kommunikationssysteme (KOM)
> Neuenahrer Straße 20, 53343 Wachtberg, Germany
> Telefon +49 228 9435-961,   Fax +49 228 9435 685
> mailto:(spam-protected) http://www.fkie.fraunhofer.de
> GPG: E1C6 0914 490B 3909 D944 F80D 4487 C67C 55EC CFE0
> 
> -- 
> Olsr-dev mailing list
> (spam-protected)
> https://lists.olsr.org/mailman/listinfo/olsr-dev