[Olsr-dev] [PATCH 06/12] mdns: remove unused variables

[Ferry Huberts]

On 06/10/2011 10:26 AM, ZioPRoTo (Saverio Proto) wrote:
> Let me see if I understand correctly this patch.
> 
> When a olsr message is received by a plugin, there is a function that
> gets the buffer received and puts everything in the standard data
> structures of the olsr message.
> 
> at a later time, not all the information in the message is used so
> there is some unused variables.
> 
> It should be no problem, but I'm afraid ...
> 
> because I see you patched many plugins at once in the stable tree, are
> you sure these patches are stable ? Because at Ninux we have a
> production network with over 70 nodes and we use both mDNS and
> nameservice plugin, so introducing a bug in those may result in a big
> problem for us.
> 
> I think this stuff should go to master branch and the when tested do a
> future backport to stable branch.
> 
> my 2 cents
> 
> comments ?
> 
> Saverio
> 
> 

I carefully checked and double checked.
Henning reviewed and suggested a push.

Next time I'll leave a bit more time before pushing.
-- 
Ferry Huberts