[Olsr-dev] [PATCH 06/12] mdns: remove unused variables

[Henning Rogge]

On Fri June 10 2011 10:26:54 ZioPRoTo (Saverio Proto) wrote:
> Let me see if I understand correctly this patch.
> 
> When a olsr message is received by a plugin, there is a function that
> gets the buffer received and puts everything in the standard data
> structures of the olsr message.
> 
> at a later time, not all the information in the message is used so
> there is some unused variables.
> 
> It should be no problem, but I'm afraid ...
> 
> because I see you patched many plugins at once in the stable tree, are
> you sure these patches are stable ? Because at Ninux we have a
> production network with over 70 nodes and we use both mDNS and
> nameservice plugin, so introducing a bug in those may result in a big
> problem for us.
> 
> I think this stuff should go to master branch and the when tested do a
> future backport to stable branch.
> 
> my 2 cents
> 
> comments ?

The patches only remove variables that are written but never read (GCC 4.6 can 
detect this). So most likely they are just left overs in the MDNS from a copy 
of other code.

Can you see any harm removing them ?

Henning
-- 
Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
Kommunikation, Informationsverarbeitung und Ergonomie FKIE
Kommunikationssysteme (KOM)
Neuenahrer Straße 20, 53343 Wachtberg, Germany
Telefon +49 228 9435-961,   Fax +49 228 9435 685
mailto:(spam-protected) http://www.fkie.fraunhofer.de
GPG: E1C6 0914 490B 3909 D944 F80D 4487 C67C 55EC CFE0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20110610/159c5f66/attachment.sig>