[Olsr-dev] Possible to fix errors in git repo?

[Aaron Daubman]

Henning,

On Fri, Jun 10, 2011 at 4:57 AM, Henning Rogge
<(spam-protected)> wrote:
> On Thu June 9 2011 19:20:36 Aaron Daubman wrote:
>> I'm working with olsrd and am using the git source repo. While a clone
>> works perfectly fine, I'm worried about future issues that the errors
>> in the current repo may cause:
>>
>> % git fsck
>> error in commit 416bcb98541f2b67a2a3abed5332a2b2cecb79a8: invalid
>> author/committer line - missing space before email
>> error in commit 693bbb3be4d43ac4dc928b83a952b007033fbe5c: invalid
>> author/committer line - missing space before email
>> error in commit ced1a09de6276b2bb8067a2e07a6ff2b7c75f3fa: invalid
>> author/committer line - bad date
>> error in commit d2b500aecf6da7dac8af1a13e52ccd623a1c9c67: invalid
>> author/committer line - missing space before email
>> error in commit e2446767975ee66658122e1fc437158ebec7693a: invalid
>> author/committer line - missing space before email
>
> I don't think they are harmfull... they are commits which were made from
> misconfigured systems (bad email/time).
>
> Does this appear anywhere except in a fsck ?


At least the bad date is harmful; if attempting to push the entire
repository to a new server (which is a common workflow when forking
and storing your fork on a backed-up/centralized location) this will
cause git pack-objects to bail:

~/sandbox/olsrd (stable) $ git remote add olsrtest2
~/sandbox/olsrd (stable) $ git push olsrtest2

Initialized empty Git repository in
/gitrepos/repositories/olsrtest2.git/
Counting objects: 19129, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5326/5326), done.
error: object ced1a09de6276b2bb8067a2e07a6ff2b7c75f3fa:invalid
author/committer line - bad date
fatal: Error in object
error: pack-objects died of signal 13
error: failed to push some refs to '(spam-protected):olsrtest2'

I'm not sure if the author/committer "missing space before email"
errors are ignored, or if the "bad date" simply causes it to fail
before getting to those.

Not a huge problem, but would ease making use of the OLSRd git repo,
especially for those of us not contributing directly to the core but
working out possible future contributions in our own sandboxes. (in
this case, pushing the original repo up to our own central repo is
very useful - we can maintain history and update the core olsrd from
your repo, while also maintaining our separate additions.)

Thanks,
     Aaron