[Olsr-dev] 3 buildbreaks in tip under windows

[L. Aaron Kaplan]

Hi!

under windows we now have a build break with the latest checkin on tip:

-cast -Wpointer-arith -Wcast-qual -Wshadow -Wformat-2 -Wsequence-point  
-Wpointer
-arith -Wcast-align -Wnested-externs -Winline -Wdisabled-optimization - 
Werror -f
inline-functions-called-once -funit-at-a-time -finline-limit=350 -O0  - 
mno-cygwi
n -ggdb -Isrc -DOLSRD_CONF_FILE_NAME='"olsrd.exe.conf"' - 
DOLSRD_GLOBAL_CONF_FILE
='"/usr/local/etc/olsrd.exe.conf"'  -DWIN32 -D_WIN32_WINNT=0x0600 -I./ 
src/win32
-DDEBUG    -c -o src/main.o src/main.c
src/main.c: In function `main':
src/main.c:194: warning: passing arg 1 of `olsr_exit' makes integer  
from pointer
  without a cast
src/main.c:194: error: too many arguments to function `olsr_exit'
make: *** [src/main.o] Error 1

It is used in windows as:
   olsr_exit(__func__, EXIT_FAILURE)

But if you look at olsr.h the function looks like this:
   olsr_exit (int)

should be easy to fix :)





Second buildbreak in windows / tip:

/usr/bin/ccache gcc -Wall -Wextra -Wold-style-definition -Wdeclaration- 
after-sta
tement -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations  
-Wsign-co
mpare -Waggregate-return -Wmissing-noreturn -Wmissing-format-attribute  
-Wno-mult
ichar -Wno-deprecated-declarations -Wendif-labels -Wwrite-strings - 
Wbad-function
-cast -Wpointer-arith -Wcast-qual -Wshadow -Wformat-2 -Wsequence-point  
-Wpointer
-arith -Wcast-align -Wnested-externs -Winline -Wdisabled-optimization - 
Werror -f
inline-functions-called-once -funit-at-a-time -finline-limit=350 -O0  - 
mno-cygwi
n -ggdb -Isrc -DOLSRD_CONF_FILE_NAME='"olsrd.exe.conf"' - 
DOLSRD_GLOBAL_CONF_FILE
='"/usr/local/etc/olsrd.exe.conf"'  -DWIN32 -D_WIN32_WINNT=0x0600 -I./ 
src/win32
-DDEBUG    -c -o src/olsr_logging.o src/olsr_logging.c
src/olsr_logging.c: In function `olsr_log':
src/olsr_logging.c:219: warning: implicit declaration of function  
`localtime_r'
src/olsr_logging.c:219: warning: nested extern declaration of  
`localtime_r'
make: *** [src/olsr_logging.o] Error 1

/usr/include/time.h has the line:
struct tm *_EXFUN(localtime_r,  (const time_t *, struct tm *));

So... it should be there...

I "fixed" that now by disabling -Werror in Makefile.inc
(BTW: can we follow Bernd's advice and really disable -Werror in  
0.5.6 ? )




Third buildbreak is this:

-Isrc -DOLSRD_CONF_FILE_NAME='"olsrd.exe.conf"' - 
DOLSRD_GLOBAL_CONF_FILE='"/usr/
local/etc/olsrd.exe.conf"'  -DWIN32 -D_WIN32_WINNT=0x0600 -I./src/ 
win32 -DDEBUG
    -c -o src/plugin_util.o src/plugin_util.c
src/plugin_util.c: In function `ip_acl_plugin_parse':
src/plugin_util.c:198: error: `in_addr_t' undeclared (first use in  
this function
)
src/plugin_util.c:198: error: (Each undeclared identifier is reported  
only once
src/plugin_util.c:198: error: for each function it appears in.)
make: *** [src/plugin_util.o] Error 1

Did not look into that yet, continuing on the FON setup...

a.