[Olsr-dev] Quagga plugin CPPFLAGS ignored

[Acinonyx]

On Thursday 11 October 2007 16:13:08 Acinonyx wrote:
> On Monday 08 October 2007 11:03:53 Immo 'FaUl' Wehrenberg wrote:
> > OK, as promised I looked over it again and did a few updates,
> > mostly fixing typos and adding patches from Bernd
> > (new plugin-interface), Hannes (new routing-core), Acinonyx
> > (Makefile-Fix) and Sven-Ola (bugfixes).
> >
> > The version from svn://dev.durchdieluft.net/olsr-quagga/trunk/quagga
> > should at least load now again (I haven't done more testing though).
> >
> > If someone could just find the time to do some additional tests and
> > give feedback it would be great.
> >
> > FaUl
>
> Thanks,
>
> I'll do some testing today and report back. :-)
>
> Vassilis


Hello again,

I compiled olsrd with gcc version 3.3.4 and had some small problem with the 
warning options suppression script so I spent some time to fix that:

diff -Nur olsrd-current/gcc-warnings olsrd-current-patched/gcc-warnings
--- olsrd-current/gcc-warnings  2007-10-11 22:08:19.000000000 +0300
+++ olsrd-current-patched/gcc-warnings  2007-10-11 22:18:30.000000000 +0300
@@ -30,7 +30,7 @@
        *error:\ unrecognized\ *option*)
                                        opt="${error#*\`}"
                                        opt="${opt%\'*}"
-                                       opt="${error#*\"}"
+                                       opt="${opt#*\"}"
                                        opt="${opt%\"*}"
                                        OPTS=`echo $OPTS | sed -e s/$opt//g`
                                        ;;


I did extensive tests on quagga plugin and "ExportRoutes" options and some 
with "redistribution". I attach a patch which fixes some issues I've 
encountered.


The fixes are:

* Update version script to include olsrd_get_plugin_parameters
* Don't send commands to zebra if disconnected
* Handle EAGAIN error on socket reading
* Fix route deletion - routes should be deleted from FIB
* Fix checking of STATUS_CONNECTED flag

Also there is some work to be done so that redistributed routes are deleted 
from olsr when connection with zebra drops.

Vassilis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-warnings-fix.patch
Type: text/x-diff
Size: 682 bytes
Desc: not available
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20071011/da301231/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: quagga-fix.patch
Type: text/x-diff
Size: 3786 bytes
Desc: not available
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20071011/da301231/attachment-0001.patch>