[olsr-dev] bug in mdi code

[Erik Tromp]

Andreas, Daniël,

If the main IP address changes, there is no problem. The existing MID sets in all other nodes time out and a new MID set is created
with the new main IP address.

The problem arises when one of the non-main IP addresses changes. The problem in the current olsr code is either that:
* individual alias entries never time out, or
* incoming MID messages are scanned for new aliases, but not scanned for removed aliases.
(whichever you like most :-)

I think we should update the code in the function olsr_process_received_mid (file process_package.c).

The following lines in that function only check for *new* MID declarations:

  while(tmp_adr)
    {
      if(!mid_lookup_main_addr(&tmp_adr->alias_addr))
       {
         OLSR_PRINTF(1, "MID new: (%s, ", olsr_ip_to_string(&message.mid_origaddr))
         OLSR_PRINTF(1, "%s)\n", olsr_ip_to_string(&tmp_adr->alias_addr))
         insert_mid_alias(&message.mid_origaddr, &tmp_adr->alias_addr, (float)message.vtime);
       }

      tmp_adr = tmp_adr->next;
    }

We should also check if there are aliases in our local set, which are no longer declared by the received MID message. If so, remove
these aliases from our local set.

Erik



----- Original Message ----- 
From: "Daniel Poelzleithner" <(spam-protected)>
To: "OLSR development" <(spam-protected)>
Sent: Monday, October 23, 2006 4:52 PM
Subject: Re: [olsr-dev] bug in mdi code


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Andreas Tønnesen wrote:
>
> > Are you saying the old entry is never deleted?
>
> Yes. It is refreshed constantly, because the new node sends the new mid,
> but the node routes to the old target, creating a black hole route. I'm
> not sure, but maybe this only occurs on the neighbor nodes connected via
> lan (at least i noticed only there).
>
> kindly regards
>   Daniel
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: GnuPT 2.7.2
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFFPOVIy/mkIQp7AD0RAl2KAKDSVDSfaOwNaDlFsuZXCKty285fUwCggmVZ
> QD9L/B/A5XR/Lo4xWD/b/+E=
> =7nWZ
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> olsr-dev mailing list
> (spam-protected)
> https://www.olsr.org/mailman/listinfo/olsr-dev
>