[Olsr-users] Missing mandatory TLV 25 in extension 256

[Mika Rajala]

Hi

Got to do a little bit testing again.

It seems that I still don't get the Session Update Response Message from dlep_router.

And I still don't find the code for this, It should be under the function _router_process_peer_update, right?

This causes a bit of an issue, because the transaction model for DLEP doesn't support multiple ongoing messages.

I have a piece of code that makes it expect certain messages when I'v sent something, I'll just go the easy way and disable my expectation of Session Update Response after sending Session Update.

-mika

-----Original Message-----
From: Henning Rogge [mailto:(spam-protected)] 
Sent: 26. helmikuuta 2016 14:35
To: Mika Rajala <(spam-protected)>
Cc: (spam-protected)
Subject: Re: [Olsr-users] Missing mandatory TLV 25 in extension 256

Good to hear...

I still have to fix a few things in netjsoninfo... as soon as this is done I will tag 0.11.0

Henning

On Fri, Feb 26, 2016 at 12:33 PM, Mika Rajala <(spam-protected)> wrote:
> Hi
>
> The head version seems to work fine.
>
> I was using the one tagged as 0.10.0
>
> I reverted all changes I made to 0.10.0 and I can confirm that it does NOT work.
>
> I send message type 4
> And I get message type 7 (terminate)
>
> So I'll just use the current head version for now.
>
> -mika
>
> -----Original Message-----
> From: Henning Rogge [mailto:(spam-protected)]
> Sent: 25. helmikuuta 2016 12:11
> To: Mika Rajala <(spam-protected)>
> Subject: Re: [Olsr-users] Missing mandatory TLV 25 in extension 256
>
> A bit more information..
>
> this is the hexdump of my message type 4 I received... it is processed by my (unmodified) router without a problem:
>
> 0004 0036
> 0005 0002 00 01
> 000c 0008 0000000000000000
> 000d 0008 0000000000000000
> 000e 0008 0000000000000000
> 000f 0008 0000000000000000
>
> (I don't transmit Latency because it is not mandatory)
>
> Could you please verify that the bug still happens with the most recent dlep_router commit (without any modifications of the code)?
>
> Henning
>
> On Thu, Feb 25, 2016 at 10:48 AM, Henning Rogge <(spam-protected)> wrote:
>> On Thu, Feb 25, 2016 at 9:54 AM, Mika Rajala <(spam-protected)> wrote:
>>> This doesn't seem to be an issue for me anymore, since it has worked 
>>> after I removed those extensions from dlep_router
>>>
>>> I won't be using them anyway.
>>>
>>> But if you want to look at this further, maybe record the Session Init Response Message from the DLEP radio with the disabled extensions and see how it compares with mine.
>>>
>>> I might do that if I find the time,  but not today atleast.
>>
>> I WANT to fix them, but I cannot reproduce them.
>>
>> I commented the two lines you also used out in my DLEP radio and it 
>> works for the router...
>>
>> Henning