[Olsr-users] Stuck TC-Edge entries in orphaned olsrd

[Joerg Pommnitz]

Hannes,
I'm not 100% sure we are talking about the same thing (see inline for
the things I don't fully understand).
I don't mind the tc_myself entry at all. The problem I see is the tc-edge 
entry for the neighbor. Plugins like dot_draw do this:

    /* Topology */  
    OLSR_FOR_ALL_TC_ENTRIES(tc) {
      OLSR_FOR_ALL_TC_EDGE_ENTRIES(tc, tc_edge) {
        ipc_print_tc_link(tc, tc_edge);
      } OLSR_FOR_ALL_TC_EDGE_ENTRIES_END(tc, tc_edge);
    } OLSR_FOR_ALL_TC_ENTRIES_END(tc);

So, the stuck entries for long gone neighbors do cause invalid output.

-- 
Regards
       Joerg

--- Hannes Gredler <(spam-protected)> schrieb am Do, 3.7.2008:

> Von: Hannes Gredler <(spam-protected)>
> 
> the reason why we do need it at all is because the SPF code

What is "it"? tc_myself or the edge entry for the neighbor?

> relies on a tc_entry
> as representation of a node in the graph. each node needs
> to have a
> representation, including ourselves.

Fine with me.

> 
> ok, so the interesting question to ask is *why* should it
> go away ? -

Once again: what "it"?

> not removing this does not cause any harm (as an edgeless
> node (which it becomes once
> the last neighbor goes away)) is not explored during SPF
> calculation,

As I understand it, tc_myself is not edgeless, that's why I
see the stuck entries in the olsrd display (the one olsrd
normally shows on the terminal) and in dot_draw.

> so the SPF calculation will terminate immediately and
> causing not any
> new routes getting installed and old ones flushed from the
> RIB.

Routing looks fine indeed.

> keeping it up forever (w/o any validity timer running) may
> avoid some ugly race
> conditions and churn.
> 
> if you feel this is not right, pls submit a patch where the
> tc_entry for ourselves
> is getting properly refreshed (read tunning timer) on every
> generation of a
> fresh tc_entry.

I might actually give this a try once I'm sure we are talking about 
the same thing...

> /hannes


      __________________________________________________________
Gesendet von Yahoo! Mail.
Dem pfiffigeren Posteingang.
http://de.overview.mail.yahoo.com