[Fwd: [OLSR-users] httpinfo compiled for WRT54G - Webinterfacelooks different]

[Andreas Tønnesen]

Hi Aldert,

Thanks for a thorough report :)

>
> oscan.lex: In function `get_conf_token':
> oscan.lex:83: warning: int format, different type arg (arg 3)
> oscan.c: At top level:
> oscan.c:1008: warning: no previous prototype for 'yylex'

This is really a flex problem as far as I can see. But I'll check more
into it - I know this has been reported earlier.

> src/net.c: In function `net_output':
> src/net.c:390: warning: int format, different type arg (arg 4)
>
> [...]
>
> src/parser.c: In function `olsr_input':
> src/parser.c:171: warning: passing arg 6 of `recvfrom' from incompatible
> pointer type
>
>
> You further use #warning to tell people about certain API changes. I would
> personally
> do this in an INSTALL or README file. If the changes breaks compatibility,
> signify it
> with a major number version change.
> Using #warning will break the compile when using -Wall (which you should
> use :)

The warnings is something I use to remid myself and other devs abouth
stuff. They are always removed from release code.
Furthermore olsrd uses -Wall, did you mean -Werror?


> these files are apparently created by the build, but not removed with make
> clean. so cvs complains about these files. Ofcourse, this also potentially
> breaks compiling for two different architectures using the same source
> tree.
> If you don't want make clean to wipe these, wipe them in a make distclean
> target.

You should try the uberclean target. That one removes all files. We
include the flex/bison generated files in the source tarball so that users
are not dependent on theese tools to build olsrd. Therefore 'make clean'
does not remove these files(and some others). uberclean is used for a
complete cleanup.

- Andreas

---------
Andreas Tønnesen
http://www.olsr.org