[OLSR-users] Questions about UniK OLSRD 0.4.4

[Takafumi Tanaka]

Hi Andreas and olsr users,

The UniK OLSRD code seems to be well written and solid.
But I found some bugs (It may be my misconception...)
Would you check them.

---
in packet.h
>>struct unknown_message
>>{
>>  olsr_u8_t          seqno;
>>  union olsr_ip_addr originator;
>>  olsr_u8_t          type;
>>};
<<struct unknown_message
<<{
<<  olsr_u16_t          seqno;
<<  union olsr_ip_addr originator;
<<  olsr_u8_t          type;
<<};

in duplicate_set.c
olsr_update_dup_entry()
>>COPY_IP(&new_iface->addr, &iface);
<<COPY_IP(&new_iface->addr, iface);
"iface" is the pointer to union olsr_ip_addr...
I think there are no tangible ill effects.

in local_hna_set.c
remove_local_hna6_entry()
>>  for(entry = local_hna4_set.next; 
>>      entry != &local_hna4_set;
>>      entry = entry->next)
<<  for(entry = local_hna6_set.next; 
<<      entry != &local_hna6_set;
<<      entry = entry->next)

in mpr_selector_set.c
>>struct mpr_selector *
>>olsr_add_mpr_selector(union olsr_ip_addr *addr, olsr_u16_t vtime)
<<struct mpr_selector *
<<olsr_add_mpr_selector(union olsr_ip_addr *addr, double vtime)

>>int
>>olsr_update_mprs_set(union olsr_ip_addr *addr, olsr_u16_t vtime)
<<int
<<olsr_update_mprs_set(union olsr_ip_addr *addr, double vtime)
It may cause loss of precision..?

in net.c
net_forward()
>>      tmp_ptf_list = ptf_list;
>>      while(tmp_ptf_list != NULL)
>>	{
>>	  tmp_ptf_list->function(packet, &outputsize);
>>	  tmp_ptf_list = tmp_ptf_list->next;
>>	}
<<      tmp_ptf_list = ptf_list;
<<      while(tmp_ptf_list != NULL)
<<	{
<<	  tmp_ptf_list->function(fwd_packet, &fwdsize);
<<	  tmp_ptf_list = tmp_ptf_list->next;
<<	}

hysteresis.c
olsr_process_hysteresis()
>>      tmp_timer = now;
>>      tmp_timer.tv_sec += NEIGHB_HOLD_TIME;
<<      tmp_timer = now;
<<      tmp_timer.tv_sec += hold_time_neighbor;
---

Thanks,
Takafumi Tanaka