[Olsr-dev] [PATCH v1 1/1] lq_packet: only report a neighbour once in a hello message

[Henning Rogge]

On Thu, Jan 19, 2017 at 9:15 PM, <(spam-protected)> wrote:

> Has it been determined why 3d2fd73a5528a9c7cdccd088f2dcca80b37e66b9 broke
> this?
>
> If it is indeed the cause and we are in a rush to solve this why not just
> revert 3d2fd73a5528a9c7cdccd088f2dcca80b37e66b9?
>
> This is broken but let's not rush fixes to resolve it.
>
> If there is a need for a drastic quick fix revert
> 3d2fd73a5528a9c7cdccd088f2dcca80b37e66b9 that attempt to handle
> fragmented packets and make sure to solve that issue correctly without
> impacting the rest of the code (BTW: the RFC says we should [its a should
> not a must]  avoid having fragments in the first place )
>

The problem is that nodes with LOTS of neighbors are quite common... every
times you run an Olsrd on a VPN concentrator in a larger network. Having
two interface hearing the same interface of a neighbor is mostly done by a
networking mistake, I have never heard about a good reason for this (we
still have to fix it proper of course).

So I don't think trading a known rare problem with a known common problem
is a good thing.

Henning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20170120/5ad652e0/attachment.html>