[Olsr-dev] [RFC] problems with multiple interfaces on the same medium + proposed solution

[Ferry Huberts]

Bad news for Henning ;-)


Conrad, I duplicated what you saw on your setup.
However, the story is a bit different than what we previously thought.

   node 97   node 61     result
   ----------------------------
   master    master      bad
   master    0.6.6.1     good
   0.6.6.1   master      bad
   0.6.6.1   0.6.6.1     good

So the problem is on the receiving side!

I did a full bisect, with node 97 on master and node 61 being bisected, 
and I can confirm Teco's suspicion: Henning's fix for fragmented hellos
breaks this:

3d2fd73a5528a9c7cdccd088f2dcca80b37e66b9 is the first bad commit
commit 3d2fd73a5528a9c7cdccd088f2dcca80b37e66b9
Author: Henning Rogge <(spam-protected)>
Date:   Mon Mar 31 11:18:30 2014 +0200

     Fix processing error for fragmented hellos


Henning, can you please take a look why this got broken?


Ferry

On 07/01/17 11:16, Conrad Lara wrote:
> Thank you for the correction on the Git repo location.
>
> I have compiled the latest master
> Version: olsr.org - pre-0.9.6-git_5ee1d70-hash_ecb831632bf30f993cce28d483e93d1a (built on 2017-01-07 01:55:21 on node97)
>
> I can duplicate the issue on master using the exact same setup and config file that I used on 0.6.6.1 that was not able to duplicate the flaw.
>
> This appears to me to have become an issue sometime after 0.6.6.1.
>
> Here it is on 5ee1d70801aad04f0ce51f4ecf97671b5f5c15a9
>
> Node 61:
> Links
> Local IP	Remote IP	Hysteresis	LinkCost
> 172.29.175.61	172.28.175.97	0.00	(1.000/0.000) INFINITE
> 172.31.175.61	172.31.175.97	0.00	(1.000/1.000) 1.000
> 172.29.175.61	172.29.175.97	0.00	(1.000/0.000) INFINITE
>
>
> Node 97:
> Links
> Local IP	Remote IP	Hysteresis	LinkCost
> 172.31.175.97	172.31.175.61	0.00	(1.000/1.000) 1.000
> 172.29.175.97	172.29.175.61	0.00	(1.000/1.000) 0.100
> 172.28.175.97	172.29.175.61	0.00	(1.000/1.000) 0.100
>
> Best Regards
> Conrad Lara
>
> ---- Ferry Huberts <(spam-protected)> wrote:
>> https://github.com/OLSR/olsrd.git
>>
>> On 06/01/17 22:44, Conrad Lara wrote:
>>>
>>> ---- Ferry Huberts <(spam-protected)> wrote:
>>>>
>>>>
>>>> On 06/01/17 21:41, Conrad Lara wrote:
>>>>>>> Ubuntu 14.04 running stock available olsr.org -
>>>>>>> 0.6.6.1-git_0000000-hash_41d32a614ae55e881b7c0456c8e3ed54 (built
>>>>>>> on 2013-10-26 05:10:52 on toyol)
>>>>>>>
>>>>>>
>>>>>> That olsrd is very very old.
>>>>>>
>>>>>> Use master.
>>>>>>
>>>>>
>>>>> I agree it is an old version and will give the latest mainline a
>>>>> test, but if this issue only occurs in master I would believe that
>>>>> would make this a regression flaw in hello message parsing and
>>>>> shouldn't we instead look at placing the code there instead of
>>>>> changing how we broadcast hello's by removing data that has
>>>>> historically been broadcasted over the network?
>>>>>
>>>>
>>>>
>>>> Once you are able to reproduce it on master and with that same setup NOT
>>>> on 0.6 then I will look into bisecting it when I'm also able to confirm
>>>> that.
>>>
>>>
>>> I believe the OLSR Git repo's may be experiencing some public access issues right now (or they have moved and my notes about the location are no longer accurate) as I am unable to access them from multiple networks to obtain the latest master branch for testing.
>>>
>>> Per: http://olsr.org/git/?p=olsrd.git;a=summary
>>>
>>> git clone git://olsr.org/olsrd.git
>>> git clone http://olsr.org/git/olsrd.git
>>>
>>> (spam-protected):~/olsrd$ git clone http://olsr.org/git/olsrd.git
>>> Cloning into 'olsrd'...
>>> fatal: unable to access 'http://olsr.org/git/olsrd.git/': The requested URL returned error: 403
>>>
>>> (spam-protected):~/olsrd$ git clone git://olsr.org/olsrd.git
>>> Cloning into 'olsrd'...
>>> fatal: unable to connect to olsr.org:
>>> olsr.org[0: 193.238.157.30]: errno=Connection timed out
>>> olsr.org[1: 2a02:60:1:1::c]: errno=Connection timed out
>>>
>>>
>>> http://www.olsr.org has the following error preventing me from double checking the main page for the git repo address.
>>>
>>> "A database query error has occurred. This may indicate a bug in the software."
>>>
>>
>> --
>> Ferry Huberts
>

-- 
Ferry Huberts