[Olsr-dev] [PATCH v1 0/9] Also consider link state

Ferry Huberts (spam-protected)
Thu Feb 11 13:53:18 CET 2016



On 11/02/16 12:49, Henning Rogge wrote:
> On Thu, Feb 11, 2016 at 12:45 PM, Ferry Huberts <(spam-protected)> wrote:
>> My use-case is that when a cable is unplugged, olsrd doesn't see this.
>> This hurts my sgw because when the relevant interface is chosen as an egress
>> interface, no new egress interface is chosen until the relevant HELLOs etc
>> time-out.
>>
>> By adding this, olsrd immediately sees the interface going down and sgw can
>> immediately choose a new egress interface.
>>
>> It makes it all more responsive.
>
> So it seems we need a config option to activate this... and we need to
> keep it "default off" otherwise we are in a world of mess with the
> embedded routers.

How so?

See my other email:

I specifically designed it such that it falls back to what we have now 
when the state could not be determined.

What I added was just extra: if the state _can_ be determined, only then 
is it actually used.


up  : state != DOWN &&  IFF_UP
down: state == DOWN || !IFF_UP  (same as !up)

note what happens when state == UNKNOWN: fallback to what we have now

>
> Which was most likely the reason why I removed the IFF_RUNNING
> detection years ago.
>
> *sigh*
>
> Henning
>

-- 
Ferry Huberts



More information about the Olsr-dev mailing list