[Olsr-dev] OLSRd v1 netjson

[Ferry Huberts]

We can review the spec together at WBM in Porto if you are there

On 07/04/16 00:28, nemesis wrote:
> Hi Ferry,
>
> On Wed, 6 Apr 2016 07:52:31 +0200, Henning Rogge <(spam-protected)> wrote:
>> On Tue, Apr 5, 2016 at 10:24 PM, Ferry Huberts <(spam-protected)>
>> wrote:
>>> Hi guys
>>>
>>>
>>> I have put together a preliminary netjson plugin for OLSRd v1.
>
> Great news :-)
>
>>> Can you please take a look, try it out and provide feedback?
>>> It currently supports the following commands:
>>> - NetworkRoutes
>>> - NetworkGraph
>>> - NetworkCollection
>>
>> Not sure "NetworkCollection" is really a "command", but it is one good
>> way to implement the interface. Especially if you only have two
>> objects to put into anyways.
>
> Right, NetworkCollection is a way to wrap multiple objects in a list.
>
> You can ignore DeviceMonitoring and DeviceConfiguration because it is
> not relevant to OLSRd.
> So I think you may want to remove references to these objects from
> README_NETJSON.
>
>>> The other commands are more work to do, so I'd rather wait for
>>> feedback on
>>> what I have so far :-)
>>>
>>>
>>> The branch is here: https://github.com/OLSR/olsrd/tree/netjson
>>>
>>>
>>>
>>> BTW working with the RFC so far, I find that the requirements are
>>> sometimes
>>> a bit vague, like 'this is a prefix' but no prescribed format for it.
>
> Feedback like this one is very important, could you be more specific and
> point out the exact section numbers?
> So I can improve those sections when I have time
>
>> That is the reason why we need more people implementing it...
>>
>> they will ask the right questions to improve the draft. *G*
>
> Exactly.
>
> Regarding feedback for the plugin, I'm not in the position to comment
> your C code, but I can
> review the JSON output if you send a few samples. Then if the output is
> correct I could
> try to install this branch on one of the nodes in Rome and play with it
> next week or so.
>
> Federico

-- 
Ferry Huberts