[Olsr-dev] [PATCH] jsoninfo: HTTP headers with CORS (if requested)

[Ferry Huberts]

On 15/05/14 21:05, Alessio wrote:
>
> Alessio <(spam-protected)> writes:
>
>> The new "httpheaders" parameter prepends HTTP headers to the reply.
>> Cross-origin resource sharing headers (CORS) are included in reply
>> allowing the json retrieval by javascript applications not served
>> by olsrd itself.
>> This will allow to easily develop js applications running directly
>> into the browser.
>
>
> Hello,  I would like to spend a few words about my patch.
>
> The use case that I've addressed is allowing someone in the mesh network
> to fetch the topology via browser in javascript and do any kind of
> computations on that data.
>
>
> I'm not sure that sending the patch in the ML is the way you prefer for
> handling patches so you can find it also on my repository [1].

ML is fine.

The patch is NAK.

You mix (unneeded) refactoring with adding functionality.
On top, the comment suggests that you're changing default behaviour, 
which is a no-go.

Minimise your patch and I'll look at it again

>
>
> I've also made a sample application, completely running into the browser
> for showing what we can do with this kind of patch; it's called MapO [2]
> (source available here [3]).
> Of course you need to point it to a reacheable node running the patched
> plugin with the "httpheaders" params set to "yes".
>
>
> [1] https://bitbucket.org/nolith/olsrd/commits/6a52798297ba8648499929f4df0332dd332fb644?at=jsoninfo
> [2] http://cloud.l0g.in/mapojs/
> [3] https://bitbucket.org/nolith/mapojs
>
> nolith
>

-- 
Ferry Huberts