[Olsr-dev] [OLSR] Fix in hash_source.sh

[Ferry Huberts]

Hi Thijs,

Thanks for reporting.

Next time please do it on the dev list, or at least CC the list

On 24/07/13 13:41, Thijs van Veen wrote:
> Hello Ferry,
> 
> I hope  you don't mind me contacting you directly, but I thought you
> were the most appropriate person to contact seeing as this concerns a
> change you made.
> 
> In make/hash_source.sh you changed the line (16)
>   "if [ "xDarwin" = "x$os" ] ; then "
> to 
>   "if [ "x$osName" == "xDarwin" ] ; then"
> 
> While this should not have too much of an effect on most systems, I
> would like to note that the '==' breaks the script for (at least) Ubuntu
> users, where the default shell ( /bin/sh ) is dash rather than bash.
> A simple (portable) fix is to revert it back to a single '=', which is
> in the POSIX standard and should therefore work for most shells.
> 
> I hope you don't take this as criticism, but rather as an attempt to
> help prevent future issues with Ubuntu users.
> https://wiki.ubuntu.com/DashAsBinSh has a list of commonly used bash
> operators and how to use/work around them to make sure dash understand
> it as well.
> 

-- 
Ferry Huberts