[Olsr-dev] we broke IPv6 in olsrd 0.6.5.1

[Ferry Huberts]

sorry, I was too fast myself, try with

> if (inet_pton(AF_INET6, addr6, &tmp_ip.v6) != 1) {



On 22/02/13 12:08, Ferry Huberts wrote:
> Don't revert yet.
>
> I think Henning got the semantics wrong:
>
>> RETURN VALUE
>>        inet_pton() returns 1 on success (network address was
>> successfully converted).  0 is returned if src does not contain a
>> character
>>        string  representing  a valid network address in the specified
>> address family.  If af does not contain a valid address family, -1
>>        is returned and errno is set to EAFNOSUPPORT.
>
>
> Please try (add the '!')
>
>>  if (!inet_pton(AF_INET6, addr6, &tmp_ip.v6)) {
>
>
>
> On 22/02/13 12:01, Saverio Proto wrote:
>> Reverting the commit fixes the problem !!! :)
>>
>> Saverio
>>
>>
>> 2013/2/22 Saverio Proto <(spam-protected)>:
>>> I did git bisect:
>>>
>>> (spam-protected):/usr/src/olsrd# git bisect good
>>> b3f05653fc085193504218e47458891acf7c495d is the first bad commit
>>> commit b3f05653fc085193504218e47458891acf7c495d
>>> Author: Henning Rogge <(spam-protected)>
>>> Date:   Mon Oct 22 15:08:56 2012 +0200
>>>
>>>          Check inet_pton return value
>>>
>>>          Coverity:
>>>
>>>          CID 739622 (#1 of 1): Unchecked return value (CHECKED_RETURN)
>>>          At (8): Calling function "inet_pton(int, char const *
>>> restrict, void * restrict)" without checking return value (as is done
>>> elsewhere 22 out of 25 times).
>>>
>>>          Signed-off-by: Henning Rogge <(spam-protected)>
>>>
>>> :040000 040000 72830d524096c795b27a1ef1155d4bff6c6b0579
>>> f79ae205a92b19e0ba2347972d457b260eb7bd48 M      src
>>> (spam-protected):/usr/src/olsrd#
>>>
>>>
>>> 2013/2/22 Henning Rogge <(spam-protected)>:
>>>> We had an important fix of IPv6 in 0.6.5.
>>>>
>>>> See commit:
>>>> 25c1167350e7a6d42c2b3938ede0d6b118efa28a
>>>>
>>>> Henning Rogge
>>>>
>>>>
>>>> On 02/22/2013 10:43 AM, Saverio Proto wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> I upgraded some nodes in Ninux to 0.6.5.1
>>>>> same configuration as always.
>>>>>
>>>>> I see that 0.6.5.1 and pre-0.6.3  are not compatible, links in IPv6 do
>>>>> not come up.
>>>>>
>>>>> I will do some further tests asap and I will try to track the problem
>>>>> with git bisect, but now I have to rush to work so don't expect
>>>>> another email very soon.
>>>>
>>>>
>>>>
>>>> --
>>>> Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
>>>> Kommunikation, Informationsverarbeitung und Ergonomie FKIE
>>>> Kommunikationssysteme (KOM)
>>>> Fraunhofer Straße 20, 53343 Wachtberg, Germany
>>>> Telefon +49 228 9435-961,   Fax +49 228 9435 685
>>>> mailto:(spam-protected) http://www.fkie.fraunhofer.de
>>>>
>>>>
>>>> --
>>>> Olsr-dev mailing list
>>>> (spam-protected)
>>>> https://lists.olsr.org/mailman/listinfo/olsr-dev
>>
>

-- 
Ferry Huberts