[Olsr-dev] [PATCH] fix olsr.init script function olsrd_write_plparam() as it wrongly removes dashes. olsrd deamon did not start when the nameservice plugin was active.

[Saverio Proto]

I cannot reproduce the bug:

(spam-protected):~# uci show olsrd
(spam-protected)[0]=olsrd
(spam-protected)[0].IpVersion=4
(spam-protected)[0].RtTableDefault=112
(spam-protected)[0].RtTable=111
(spam-protected)[0]=LoadPlugin
(spam-protected)[0].library=olsrd_arprefresh.so.0.1
(spam-protected)[1]=LoadPlugin
(spam-protected)[1].library=olsrd_nameservice.so.0.3
(spam-protected)[1].name=my-name.mesh
(spam-protected)[2]=LoadPlugin
(spam-protected)[2].library=olsrd_txtinfo.so.0.1
(spam-protected)[2].accept=0.0.0.0
(spam-protected)[0]=Interface
(spam-protected)[0].interface=lan
(spam-protected)[0].speed=7
(spam-protected)[0]=Hna4
(spam-protected)[0].netaddr=10.183.2.0
(spam-protected)[0].netmask=255.255.255.0

(spam-protected):~# cat /var/etc/olsrd.conf | grep nameservice -A 5
LoadPlugin "olsrd_nameservice.so.0.3"
{
        PlParam "name" "my-name.mesh"
}


Send me also your /etc/config/olsrd please.

thanks

Saverio




2013/4/25 Saverio Proto <(spam-protected)>:
> Can you send me the UCI configuration that was not working for you
> before the patch ?
>
> thanks
>
> Saverio
>
>
> 2013/4/25 Thomas Huehn <(spam-protected)>:
>> Signed-off-by: Thomas Huehn <(spam-protected)>
>> ---
>>  olsrd/files/olsrd.init | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/olsrd/files/olsrd.init b/olsrd/files/olsrd.init
>> index 7ffe33c..f4641aa 100644
>> --- a/olsrd/files/olsrd.init
>> +++ b/olsrd/files/olsrd.init
>> @@ -153,8 +153,11 @@ olsrd_write_plparam() {
>>                 return 1
>>         fi
>>
>> -       oldIFS="$IFS"; IFS='-_'; set -- $option; IFS="$oldIFS"
>> +       oldIFS="$IFS"
>> +       IFS='-_'
>> +       set -- $option
>>         option="$*"
>> +       IFS="$oldIFS"
>>         _option="$option"
>>
>>         if [ "$option" = 'hosts' ]; then
>> --
>> 1.8.1.3
>>