[Olsr-dev] libnetlink, linux and olsr
Thu Oct 25 15:55:18 CEST 2012
On Mon, 2012-10-22 at 11:01 +0200, Henning Rogge wrote:
> On 10/19/2012 11:06 AM, Kees-Jan Hermans wrote:
> > Ok. Here's the diff. I must verify a few things with you:
> > - The way to 'transport' a configuration value to the module is now via
> > global variables and 'extern' definitions in the yacc file. Which is
> > IMHO, a kludge - ugly C. I couldn't find an example of how to do this
> > properly in other lq plugins though.
> Yes... you need to add a variable to the global "olsr config" struct.
Ok. But that wouldn't be so different from creating a global variable.
> > - I have assumed that the $(OS) definitions as used in the Makefile
> > aren't somehow mutually inclusive. That is, 'android' doesn't also
> > trigger 'linux'.
> OS=Android implies __linux__ of course.
> But the OS variable itself can only contain a single value.
Well then this should work - I'll create a branch.
> > - I made adjustments to Makefile.inc in what I don't know are the right
> > place.
> > - The configuration names as in the lex file are the result of my
> > imagination. I camelcased what I thought would be proper. Feel free to
> > adjust.
> > KJ
> > - There is still no way to separate out the older libnl libraries (which
> > have completely different names). So keep expectations low - I expect
> > errors.
Link errors mainly.
> Henning Rogge
More information about the Olsr-dev