[Olsr-dev] [PATCH v1 1/1] android: remove regex code and update API level

[Hans-Christoph Steiner]

On 10/17/2012 03:39 AM, Henning Rogge wrote:
> On 10/16/2012 09:45 PM, Hans-Christoph Steiner wrote:
>>
>> Its easy to get the NDK going on Debian or Ubuntu, install a couple
>> packages and untar the NDK..  I recommend untarring it in /opt and
>> making a symlink to the current version called /opt/android-ndk
> 
> Here is a new patch, which replace the old one. It compiled (on my machine)
> with the latest Android NDK.
> 
> But I noticed two "not nice" things:
> 
>> In file included from ../../src/lq_packet.h:48,
>>                  from ../../src/lq_plugin.h:48,
>>                  from ../../src/two_hop_neighbor_table.h:47,
>>                  from src/olsrd_plugin.h:61,
>>                  from src/olsrd_httpinfo.h:49,
>>                  from src/admin_interface.c:47:
>> ../../src/ipcalc.h: In function 'is_prefix_niit_ipv6':
>> ../../src/ipcalc.h:166: warning: dereferencing type-punned pointer
>> will break strict-aliasing rules
> 
> Seems to be a problem with IN6_IS_ADDR_V4MAPPED(&p->prefix.v6), no clue how to
> fix this warning.

I'm not seeing this warning on my machine.  I'm using NDK r8b.


> 2nd one:
> 
> /opt/android-ndk/toolchains/arm-linux-androideabi-4.4.3/prebuilt/linux-x86/bin/../lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin/ld:
> Warning: /opt/android-ndk/platforms/android-4/arch-arm/usr/lib/crtend_so.o:
> Unknown EABI object attribute 44
> 
> Seems to be a problem with the NDK itself, I found some people complaining
> about it on the internet.

I think you can ignore this one, based on my vague recollection of when I
looked into it.

The patch works for me, I'm fine with it being committed to master.


.hc