[Olsr-dev] [PATCH v1 1/1] android: remove regex code and update API level

[Hans-Christoph Steiner]

On 10/16/2012 08:55 AM, Henning Rogge wrote:
> On 10/15/2012 05:33 PM, Hans of Guardian wrote:
>>
>> On Oct 15, 2012, at 11:18 AM, Henning Rogge wrote:
>>
>>> On Mon, Oct 15, 2012 at 5:14 PM, Hans of Guardian
>>> <(spam-protected)> wrote:
>>>> A working build systems means you only rebuild the changed files,
>>>> and those affected by it.  So you should only see those regex
>>>> warnings once when you first compile.  So that's another approach
>>>> to solving this issue.  Then you don't have to look through long
>>>> build logs every time.
>>>
>>> I prefer to have my compilation STOP when I work on code and made
>>> an error... at least thats my personal preference.
>>>
>>>> One thing that would help with this goal is to remove the
>>>> builddata.c kludge.  These can be set using macros defined from
>>>> the command line:
>>>>
>>>> -DOLSRD_VERSION='"olsr.org -
>>>> 0.6.3-git_a9c9b25-hash_7c4d4af59e8bb9c9dd2cb85eb4815c17  -"'
>>>
>>> This will not help that much, because you have then to recompile
>>> the code that use this defines.
>>>
>>> In the new framework I put this data into a static library of its
>>> own, so it has no direct connection to the rest of the
>>> API/program.
>>
>> These two approaches would have the exact same effect.  If this stuff
>> was in builddata.c, then the -DOLSRD_VERSION would only matter when
>> you build builddata.o, then make wouldn't try to build builddata.o
>> again until builddata.c changed.  make would not try to build
>> builddata.o again based on different CFLAGS unless you do some crazy
>> tricks.
> 
> You are looking for something that works well for tarballs without
> patching the makefile, right?

That would be one benefit of this change, it would also work better with
make dependency tracking.  Right now, things that depend on
src/buildddata.c will be rebuilt every time since that file is
regenerated every time.

.hc