[Olsr-dev] [PATCH v1 1/1] android: remove regex code and update API level

[Hans of Guardian]

On Oct 15, 2012, at 11:20 AM, Ferry Huberts wrote:

> 
> 
> On 15-10-12 17:14, Hans of Guardian wrote:
>> 
>> On Oct 15, 2012, at 11:08 AM, Henning Rogge wrote:
>> 
>>> On Mon, Oct 15, 2012 at 5:03 PM, Hans of Guardian
>>> <(spam-protected)> wrote:
>>>> On Oct 15, 2012, at 11:00 AM, Henning Rogge wrote:
>>>>> On Mon, Oct 15, 2012 at 4:55 PM, Ferry Huberts
>>>>> <(spam-protected)> wrote:
>>>>>> Then please work with Henning in making the regex library a
>>>>>> standalone static library with it's own makefile.
>>>>> I will look into it and Hans can test it...
>>>> What benefit would this provide us?
>>> 
>>> Less warnings mean you recognize the one that is relevant more
>>> easily.
>>> 
>>> Its the same with valgrind problems... as soon as you have lots of
>>> "irrelevant ones", you easily miss the relevant ones.
>> 
>> A working build systems means you only rebuild the changed files, and
>> those affected by it.  So you should only see those regex warnings
>> once when you first compile.  So that's another approach to solving
>> this issue.  Then you don't have to look through long build logs
>> every time.
> 
> Not in a build server.
> My build server does:
> git clean -fdx
> git reset --hard
> git pull
> make ...
> 
> 
> I want the build log to clearly show me real warnings and not a gazillion warnings that I can (according to you) ignore.
> 
> Can I propose that something is added to the build system so that we have API level 8, but can enable API level 5 with an option?

How about just making -Werror apply everywhere but that regex code?  I think that'll be a lot easier to manage.

Making the regex stuff conditionally link in will make deploying olsrd on Android more painful since an olsrd built without regex will not run on android-7.  And debugging that kind of error on Android is painful, take it from someone whose ported GnuPG, ffmpeg, LUKS, tcptraceroute, etc to Android.  It will make it harder for other people to put olsrd in their own apps.

.hc