[Olsr-dev] Android build & regex
Mon Oct 15 11:20:27 CEST 2012
On 10/15/2012 11:11 AM, Ferry Huberts wrote:
> Can we please get rid of the regex code in our source tree and use the
> Android regex library?
> Android includes the regex library since API level 8, which is Froyo/2.2.x
> Removing the regex library in our source tree would make us not support
> Eclair, Donut, Cupcake and Base.
> According to http://developer.android.com/about/dashboards/index.html,
> these versions currently amount to 3.9% market share.
I think the problem was (and is) that quite a few non-market capable
Android devices (for example all the first generation Amazon tablets)
are not supporting the regex library.
Google does only count devices that can access the Google Market.
> Since you have to have a rooted phone and perform some magic on it I
> propose that we can easily say that we don't support phones that old.
> I want to get rid of the regex code in our tree because it basically
> unneeded (looking at the market figures) and because it throws a
> gazillion warnings in the build; it prevents us from (for example)
> adding the -Werror compiler flag.
In my "olsr.org network framework" I moved the regex code into a static
library of its own with its own makefile. That might be a good
compromise if we keep regex.
Thoughts about -Werror:
I know the flag is not "loved" by quite a few programmers. Maybe we
should activate it when we create a new release branch and deactivate it
before we release.
This way we make sure the current compiler warnings get fixed before a
Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
Kommunikation, Informationsverarbeitung und Ergonomie FKIE
Fraunhofer Straße 20, 53343 Wachtberg, Germany
Telefon +49 228 9435-961, Fax +49 228 9435 685
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6169 bytes
Desc: S/MIME Cryptographic Signature
More information about the Olsr-dev