[Olsr-dev] "-Werror" for master branch - was: merge mDNS branch to master

[Hans-Christoph Steiner]

If you want to drive away contributors, then I think this is a good
idea.  How about instead we encourage people to do the right thing, and
let them actually do the work needed?  Others won't learn if you don't
let them fix their mistakes and commit them.

.hc

On 10/11/2012 04:43 AM, Ferry Huberts wrote:
> 
> 
> On 11-10-12 10:28, Henning Rogge wrote:
>> I wonder if we should add the "-Werror" flag to our makefile in the
>> master branch and only remove it in the release branches.
> 
> That would break the android build
> 
> Linux build is ok with this.
> Since Linux is my only interest, I don't mind.
> 
>>
>> Henning Rogge
>>
>> On 10/11/2012 10:25 AM, ZioPRoTo (Saverio Proto) wrote:
>>> thanks Ferry.
>>>
>>> Saverio
>>>
>>>
>>> 2012/10/11 Ferry Huberts <(spam-protected)>:
>>>>
>>>>
>>>> On 10-10-12 09:03, Ferry Huberts wrote:
>>>>>
>>>>>
>>>>>
>>>>> On 28-09-12 14:54, ZioPRoTo (Saverio Proto) wrote:
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> we would like to merge mDNS-plugin-GSoC-2012 branch to master
>>>>>>
>>>>>> if okay I will do that in a few days.
>>>>>>
>>>>>> thanks
>>>>>>
>>>>>> Saverio
>>>>>>
>>>>>
>>>>>
>>>>> Saverio,
>>>>>
>>>>> can you please fix the following compile warnings?
>>>>>
>>>>
>>>> Don't bother. I fixed them for you
>>>>
>>>>
>>>>>
>>>>>> make[1]: Entering directory `/home/ferry/vcs/nbs/nbsolsrd/lib/mdns'
>>>>>> [CC] src/olsrd_plugin.c
>>>>>> [CC] src/Address.c
>>>>>> [CC] src/RouterElection.c
>>>>>> [CC] src/Packet.c
>>>>>> [CC] src/NetworkInterfaces.c
>>>>>> [CC] src/mdns.c
>>>>>> src/mdns.c: In function ‘isInFilteredList’:
>>>>>> src/mdns.c:406:7: warning: passing argument 2 of ‘olsr_ip_to_string’
>>>>>> from incompatible pointer type [enabled by default]
>>>>>> In file included from src/mdns.c:65:0:
>>>>>> ../../src/ipcalc.h:146:1: note: expected ‘const union olsr_ip_addr *’
>>>>>> but argument is of type ‘struct in_addr *’
>>>>>> src/mdns.c:406:7: warning: passing argument 2 of ‘olsr_ip_to_string’
>>>>>> from incompatible pointer type [enabled by default]
>>>>>> In file included from src/mdns.c:65:0:
>>>>>> ../../src/ipcalc.h:146:1: note: expected ‘const union olsr_ip_addr *’
>>>>>> but argument is of type ‘struct in_addr *’
>>>>>> src/mdns.c:411:7: warning: passing argument 2 of ‘olsr_ip_to_string’
>>>>>> from incompatible pointer type [enabled by default]
>>>>>> In file included from src/mdns.c:65:0:
>>>>>> ../../src/ipcalc.h:146:1: note: expected ‘const union olsr_ip_addr *’
>>>>>> but argument is of type ‘struct in6_addr *’
>>>>>> src/mdns.c:411:7: warning: passing argument 2 of ‘olsr_ip_to_string’
>>>>>> from incompatible pointer type [enabled by default]
>>>>>> In file included from src/mdns.c:65:0:
>>>>>> ../../src/ipcalc.h:146:1: note: expected ‘const union olsr_ip_addr *’
>>>>>> but argument is of type ‘struct in6_addr *’
>>>>>> [LD] olsrd_mdns.so.1.0.1
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> -- 
>>>> Ferry Huberts
>>>
>>
>>
>>
>>
>