[Olsr-dev] [RFC] [PATCH v1 0/7] keep track of the active gateways in a list

Henning Rogge (spam-protected)
Sun Nov 25 17:19:46 CET 2012

Sorry for taking that long to review the patches, but I think they
look fine for me.

I am looking forward to see the next steps beyond them.

I suggest we do some last "look hard at Coverity issues" session in
the next 1-2 weeks, after this we can create a new release branch and
merge your patches afterwards (as you asked for).


On Tue, Nov 13, 2012 at 11:32 AM, Ferry Huberts <(spam-protected)> wrote:
> From: Ferry Huberts <(spam-protected)>
> Review and comments are requested.
> This patch series modifies the gateway code so that we now keep the active
> gateway(s) (1 for the current situation) in an ordered (on costs) list.
> This is the basis for working towards enablement of multi-gateway functionality
> as discussed earlier on the dev mailing list by Teco and me. We are working
> towards that.
> The advantage of having multiple gateways active at the same time is that we
> avoid breaking connections because running connections via gateway 1 will not
> be terminated when we pick gateway 2 as the new default gateway (as long as
> gateway 1 doesn't disappear).
> Ferry Huberts (7):
>   gateway: store current gateway(s) in a struct
>   gateway: lazily allocate the current gateway structs
>   gateway: add path_cost to 'set gateway' interface
>   gateway: add interface to get the gateway costs
>   gateway: simplify by using the new costs interface
>   gateway: add gateway_list.{c,h}
>   gateway: keep track of the active gateways in a list
>  src/gateway.c                 | 226 ++++++++++++++++++++++++++++++------------
>  src/gateway.h                 |  10 +-
>  src/gateway_default_handler.c |  77 +++++++-------
>  src/gateway_list.c            | 187 ++++++++++++++++++++++++++++++++++
>  src/gateway_list.h            | 152 ++++++++++++++++++++++++++++
>  5 files changed, 554 insertions(+), 98 deletions(-)
>  create mode 100644 src/gateway_list.c
>  create mode 100644 src/gateway_list.h
> --

Steven Hawkings about cosmic inflation: "An increase of billions of
billions of percent in a tiny fraction of a second. Of course, that
was before the present government."

More information about the Olsr-dev mailing list