[Olsr-dev] default_lq_serialize_hello_lq_pair_ffeth

[Ferry Huberts]

On 13/11/12 13:44, Henning Rogge wrote:
> On 11/13/2012 01:42 PM, Ferry Huberts wrote:
>>
>>
>> On 13/11/12 13:40, Henning Rogge wrote:
>>> On 11/13/2012 01:37 PM, Ferry Huberts wrote:
>>>> The function 'default_lq_serialize_hello_lq_pair_ffeth'
>>>>
>>>> puts the lq and nlq values on bytes 2 and 3 while all the other plugins
>>>> put those values in bytes 0 and 1.
>>>>
>>>> Is there some special reason for this that I'm not aware of?
>>>
>>> Could be a way to make sure you don't mix up the different routing
>>> metrics, similar to the trick we did for the etxff_eth metric (it also
>>> used byte 2/3 I think).
>
>> that makes no sense, we have several different lq plugins, each with
>> different semantics in these bytes...
>
> We have a couple of standard metrics (etx_float, etxff, etxfpm) which
> use the bytes 0/1 and are all compatible with each other.
>
> And we have one/two experimental metrics (which accidently both use byte
> 2/3).
>
also, the readme says

'The message format of etx_ff is compatible with etx_fpm and etx_float.'


It seems to me that we need to include (missing now!) a value in the 
packet to indicate which plugin is used to handle the LQ values...


-- 
Ferry Huberts