[Olsr-dev] [PATCH v1 0/4] Make olsrd build on win64 (mingw64)

[Henning Rogge]

I agree... with Hans, the rest of the patches look okay.

Henning

On Fri, Nov 9, 2012 at 7:03 PM, Hans of Guardian
<(spam-protected)> wrote:
>
> Seems ok to me, but I don't know that much about olsrd on Windows. One small correction: you should also remove the comment about getpid() / PID:
>
>   /* Using PID as random seed */
> -  srandom(getpid());
> +  srandom(random());
>
> .hc
>
> On Nov 9, 2012, at 11:59 AM, Ferry Huberts wrote:
>
>> From: Ferry Huberts <(spam-protected)>
>>
>> These patches are needed to make olsrd build on mingw64 for
>> 64 bits windows.
>>
>> Please review and ack, so that I can add a jenkins win64 target.
>>
>>
>> Ferry Huberts (4):
>>  main: do not seed the random number generator with the process id
>>  win32: remove unused getpid() function
>>  hna_set: explicitly cast to (time_t *) in calls to localtime()
>>  neighbor_table: explicitly cast to (time_t *) in calls to localtime()
>>
>> src/hna_set.c        | 2 +-
>> src/main.c           | 2 +-
>> src/neighbor_table.c | 2 +-
>> src/win32/compat.c   | 7 -------
>> src/win32/unistd.h   | 2 --
>> 5 files changed, 3 insertions(+), 12 deletions(-)
>>
>> --
>> 1.7.11.7
>>
>>
>> --
>> Olsr-dev mailing list
>> (spam-protected)
>> https://lists.olsr.org/mailman/listinfo/olsr-dev
>
>
> --
> Olsr-dev mailing list
> (spam-protected)
> https://lists.olsr.org/mailman/listinfo/olsr-dev



-- 
Steven Hawkings about cosmic inflation: "An increase of billions of
billions of percent in a tiny fraction of a second. Of course, that
was before the present government."