[Olsr-dev] [PATCH v3 1/1] linux: add support for common (autoconf) make variables (v3)

Hans-Christoph Steiner (spam-protected)
Thu Jun 21 21:10:10 CEST 2012

On 06/21/2012 02:31 PM, Ferry Huberts wrote:
> On 21-06-12 20:14, Hans-Christoph Steiner wrote:
>> So far, Ferry only posted changes related to the build system of pud.
>> The only thing broken with the most recent usrlocal patch was actually
>> with PUD:
>> - PUD did not use the global variables and instead hardcoded 'usr/lib'
>> in lib/pud/wireformat/Makefile
>> https://lists.olsr.org/pipermail/olsr-dev/2012-June/005447.html
>> - PUD was introducing new global variables for things that are only used
>> internally to PUD (INCLUDEDIR).
>> https://lists.olsr.org/pipermail/olsr-dev/2012-June/005486.html
>> PUD added some variables related to installing docs, which is a good
>> thing.  I'll leave that to Ferry to sort out, since I think he already
>> did it.
>> So I pushed this god forsaken patch and hereby declare myself done with
>> this topic.  If anyone does not want this patch in olsrd.git, I will
> Hans,
> I'm not amused that you completely ignored my fix to your patch.
> After your push the install was incorrect for PUD since it uses the
> SHAREDIR variable which you forgot to override, and which I fixed in
> your patch.
> You talked about me causing more work for you, while you now achieved
> the exact same opposite.
> This is no way to work together on improving the codebase.
> Please let go of your 'my patch' attitude and let's work together

Sorry I missed the SHAREDIR stuff, that was added after this patch was
written and is only used in PUD, so I missed it.


More information about the Olsr-dev mailing list