[Olsr-dev] [PATCH v1 01/19] gateway: clarify header with extra comments and ordering

[Henning Rogge]

On 08/23/2012 03:12 PM, Ferry Huberts wrote:
> From: Ferry Huberts <(spam-protected)>
>
> Signed-off-by: Ferry Huberts <(spam-protected)>
> ---
>   src/gateway.h | 46 ++++++++++++++++++++++++++++++++++------------
>   1 file changed, 34 insertions(+), 12 deletions(-)
>
> diff --git a/src/gateway.h b/src/gateway.h
> index c6f6bdb..3c67ef6 100644
> --- a/src/gateway.h
> +++ b/src/gateway.h
> @@ -83,16 +83,6 @@ AVLNODE2STRUCT(node2gateway, struct gateway_entry, node);
>   /** the gateway tree */
>   extern struct avl_tree gateway_tree;
>
> -void refresh_smartgw_netmask(void);
> -int olsr_init_gateways(void);
> -void olsr_cleanup_gateways(void);
> -void olsr_trigger_inetgw_startup(void);
> -void olsr_trigger_gatewayloss_check(void);
> -
> -void olsr_update_gateway_entry(union olsr_ip_addr *originator, union olsr_ip_addr *mask, int prefixlen, uint16_t seqno);
> -void olsr_delete_gateway_entry(union olsr_ip_addr *originator, uint8_t prefixlen);
> -void olsr_print_gateway_entries(void);
> -
>   /**
>    * The callback list for a gateway plugin
>    */
> @@ -103,11 +93,43 @@ struct olsr_gw_handler {
>     void (* handle_delete_gw)(struct gateway_entry *); /**< the gateway deletion callback */
>   };
>
> +/*
> + * Main Interface
> + */
> +
> +int olsr_init_gateways(void);
> +void olsr_cleanup_gateways(void);
> +void olsr_trigger_inetgw_startup(void);
> +void olsr_print_gateway_entries(void);
> +
> +/*
> + * Tx Path Interface
> + */
> +
> +void olsr_modifiy_inetgw_netmask(union olsr_ip_addr *mask, int prefixlen);
> +
> +/*
> + * SgwDynSpeed Plugin Interface
> + */

Can we maybe put an explanation in here what this function is used for 
instead of referring to a special plugin?

> +void refresh_smartgw_netmask(void);
> +
> +/*
> + * TC/SPF/HNA Interface
> + */
> +
> +bool olsr_is_smart_gateway(struct olsr_ip_prefix *prefix, union olsr_ip_addr *net);
> +void olsr_update_gateway_entry(union olsr_ip_addr *originator, union olsr_ip_addr *mask, int prefixlen, uint16_t seqno);
> +void olsr_delete_gateway_entry(union olsr_ip_addr *originator, uint8_t prefixlen);
> +void olsr_trigger_gatewayloss_check(void);
> +
> +/*
> + * Gateway Plugin Functions
> + */
> +
>   void olsr_set_inetgw_handler(struct olsr_gw_handler *l);
>   bool olsr_set_inet_gateway(union olsr_ip_addr *originator, bool ipv4, bool ipv6, bool external);
>   struct gateway_entry *olsr_get_ipv4_inet_gateway(bool *);
>   struct gateway_entry *olsr_get_ipv6_inet_gateway(bool *);
> -bool olsr_is_smart_gateway(struct olsr_ip_prefix *prefix, union olsr_ip_addr *net);
> -void olsr_modifiy_inetgw_netmask(union olsr_ip_addr *mask, int prefixlen);
>
>   #endif /* GATEWAY_H_ */
>


-- 
Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
Kommunikation, Informationsverarbeitung und Ergonomie FKIE
Kommunikationssysteme (KOM)
Neuenahrer Straße 20, 53343 Wachtberg, Germany
Telefon +49 228 9435-961,   Fax +49 228 9435 685
mailto:(spam-protected) http://www.fkie.fraunhofer.de
GPG: E1C6 0914 490B 3909 D944 F80D 4487 C67C 55EC CFE0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6169 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20120824/94423cd2/attachment.bin>