[Olsr-dev] change to olsr_rt_flags() function in BSD but not Linux in stable branch

[Hans-Christoph Steiner]

Yeah, it failed.  This is a strange Makefile system, it seems quite fragile.

.hc

On Apr 6, 2012, at 1:53 PM, Henning Rogge wrote:

> I am not sure this will be enough, because the main directories are
> also included by wildcards. Not sure we should change this for the
> stable anymore, lots of work for not that much gain.
> 
> The framework which will be the base of the next release of OLSRd will
> have no such wildcards from the beginning.
> 
> Henning Rogge
> 
> On Fri, Apr 6, 2012 at 16:05, Hans-Christoph Steiner
> <(spam-protected)> wrote:
>> 
>> On Apr 6, 2012, at 3:41 AM, Markus Kittenberger wrote:
>> 
>> 
>> 
>> On Fri, Apr 6, 2012 at 9:03 AM, Ferry Huberts <(spam-protected)>
>> 
>>> I agree.
>>> 2.4 is _completely_ ancient and not worth the effort to maintain.
>> 
>> btw its not about 2.4!
>> (which olsrd definetley gets maintaned/tested/used on) as there are still
>> hundreds of router i know of running with 2.4
>> 
>> as netlink is around since 2.2!!!!
>> 
>> so for dropping ioctl we where talking about much older linux than 2.4 (-;
>> 
>> Markus
>> 
>> 
>> While we are at it, I'd like to suggest explicitly listing the files to be
>> built in the Linux Makefile rather than using a wildcard. A build system is
>> there to make sure the build is repeatable and reliable.  The presence or
>> absence of any given file needed for olsrd is something that the build
>> system should be aware of.  The only way I know to do that is to list out
>> the files that the build system should be aware of.  Something like this:
>> 
>> 
>> --- a/make/Makefile.linux
>> +++ b/make/Makefile.linux
>> @@ -6,8 +6,14 @@ ARCH := $(shell uname -m)
>>  DESTDIR ?=
>>  LIBDIR =       $(DESTDIR)/usr/lib
>> 
>> -SRCS +=        $(wildcard src/linux/*.c src/unix/*.c)
>> -HDRS +=                $(wildcard src/linux/*.h src/unix/*.h)
>> +SRCS += src/linux/apm.c \
>> +       src/linux/kernel_routes_nl.c \
>> +       src/linux/kernel_tunnel.c \
>> +       src/linux/link_layer.c \
>> +       src/linux/net.c \
>> +       src/unix/ifnet.c \
>> +       src/unix/log.c \
>> +       src/unix/misc.c
>> 
>>  CPPFLAGS +=    -Dlinux -DLINUX_NETLINK_ROUTING
>>  LIBS +=
>> 
>> 
>> .hc
>> 
>> 
>> 
>> --
>> Olsr-dev mailing list
>> (spam-protected)
>> https://lists.olsr.org/mailman/listinfo/olsr-dev
> 
> 
> 
> -- 
> Steven Hawkings about cosmic inflation: "An increase of billions of
> billions of percent in a tiny fraction of a second. Of course, that
> was before the present government."