[Olsr-dev] change to olsr_rt_flags() function in BSD but not Linux in stable branch

[Hans-Christoph Steiner]

On Apr 6, 2012, at 3:41 AM, Markus Kittenberger wrote:

> 
> 
> On Fri, Apr 6, 2012 at 9:03 AM, Ferry Huberts <(spam-protected)> 
> 
> I agree.
> 2.4 is _completely_ ancient and not worth the effort to maintain.
> btw its not about 2.4!
> (which olsrd definetley gets maintaned/tested/used on) as there are still hundreds of router i know of running with 2.4 
> 
> as netlink is around since 2.2!!!! 
> 
> so for dropping ioctl we where talking about much older linux than 2.4 (-;
> 
> Markus

While we are at it, I'd like to suggest explicitly listing the files to be built in the Linux Makefile rather than using a wildcard. A build system is there to make sure the build is repeatable and reliable.  The presence or absence of any given file needed for olsrd is something that the build system should be aware of.  The only way I know to do that is to list out the files that the build system should be aware of.  Something like this:


--- a/make/Makefile.linux
+++ b/make/Makefile.linux
@@ -6,8 +6,14 @@ ARCH := $(shell uname -m)
 DESTDIR ?=
 LIBDIR =       $(DESTDIR)/usr/lib
 
-SRCS +=        $(wildcard src/linux/*.c src/unix/*.c)
-HDRS +=                $(wildcard src/linux/*.h src/unix/*.h)
+SRCS += src/linux/apm.c \
+       src/linux/kernel_routes_nl.c \
+       src/linux/kernel_tunnel.c \
+       src/linux/link_layer.c \
+       src/linux/net.c \
+       src/unix/ifnet.c \
+       src/unix/log.c \
+       src/unix/misc.c
 
 CPPFLAGS +=    -Dlinux -DLINUX_NETLINK_ROUTING
 LIBS +=                


.hc


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20120406/3acaf4b7/attachment.html>