[Olsr-dev] change to olsr_rt_flags() function in BSD but not Linux in stable branch
Thu Apr 5 20:01:26 CEST 2012
In theory the ioctl-code could be removed, netlink code should run
fine on linux 2.4 or better.
On Thu, Apr 5, 2012 at 19:56, Hans-Christoph Steiner
> I just noticed something while rebasing my patches against the HEAD of stable. In the commit called "fix bsd RTM_GATEWAY routing flags detection" by Markus Kittenberger (66dcc5f8e3da8084cef0fcec3a4580d47b90f593), the function olsr_rt_flags() was changed to have a second parameter:
> olsr_rt_flags(const struct rt_entry *, int add);
> This change was made in src/process_routes.h, src/process_routes.c, and src/bsd/kernel_routes.c but was not made in src/linux/kernel_routes_ioctl.c. Yet, olsrd seems to build and run fine. My guess is that src/linux/kernel_routes_ioctl.c is not used at all, even though its being included it the build.
> If src/linux/kernel_routes_ioctl.c is not used, can it be removed? If it is, then olsr_rt_flags() should be updated there.
> On a related note, I setup an automated build on Debian/stable/amd64 and also runs olsrd using fakeroot after it builds:
> Olsr-dev mailing list
Steven Hawkings about cosmic inflation: "An increase of billions of
billions of percent in a tiny fraction of a second. Of course, that
was before the present government."
More information about the Olsr-dev