[Olsr-dev] [PATCH 2/4] smart gateway: do not stop choosing a new (better) gateway

[Henning Rogge]

On 12/06/2011 10:14 AM, Ferry Huberts wrote:
> From: Ferry Huberts<(spam-protected)>
>
> Signed-off-by: Ferry Huberts<(spam-protected)>
> ---
>   src/gateway_default_handler.c |    6 ------
>   1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/src/gateway_default_handler.c b/src/gateway_default_handler.c
> index a18dba8..50986b3 100644
> --- a/src/gateway_default_handler.c
> +++ b/src/gateway_default_handler.c
> @@ -76,12 +76,6 @@ static void gw_default_choose_gateway(void) {
>     if (inet_ipv6&&  !dual) {
>       olsr_set_inet_gateway(&inet_ipv6->originator, false, true, false);
>     }
> -
> -  /* finished ? */
> -  if (gw_def_finished_ipv4&&  gw_def_finished_ipv6) {
> -    olsr_stop_timer(gw_def_timer);
> -    gw_def_timer = NULL;
> -  }
>   }
>
>   /* timer for lazy gateway selection */

Have to look at this more closely. The idea behind the "default" gateway 
selector is to select a gateway and stick with it until its gone. Maybe 
"gone" is a bit too late, but if we start choosing another gateway too 
early, we might get gateway-flapping again.

Henning

-- 
Diplom-Informatiker Henning Rogge , Fraunhofer-Institut für
Kommunikation, Informationsverarbeitung und Ergonomie FKIE
Kommunikationssysteme (KOM)
Neuenahrer Straße 20, 53343 Wachtberg, Germany
Telefon +49 228 9435-961,   Fax +49 228 9435 685
mailto:(spam-protected) http://www.fkie.fraunhofer.de
GPG: E1C6 0914 490B 3909 D944 F80D 4487 C67C 55EC CFE0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6156 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20111208/fadd38f2/attachment.bin>