[Olsr-dev] dot-draw-plugin closing connection

ZioPRoTo (Saverio Proto) (spam-protected)
Thu Mar 25 16:11:07 CET 2010


> probably Bug. Typical dot-draw client does not handle disconnects AFAIK.

OK, looks like the bug was introduced here:

http://olsr.org/git/?p=olsrd.git;a=commitdiff;h=58d5acd9d2d27efbdcad2d5f6df681e97a3f7459

look at the function dotdraw_write_data

If the topology did not change and the buffer is 0 then the plugin
closes the connection.

At line 306 of file  olsrd_dot_draw.c

     if (result <= 0) {

Should be:

    if (result < 0) {

I'm testing the patch on my testbed and seems to work. When you close
your telnet the connection is correctly closed, but not before.

Should I patch commit and push ?

Saverio




More information about the Olsr-dev mailing list