[Olsr-dev] Fwd: Bug#532573: olsrd: olsrd_dot_draw does not honor the "accept" parameter

[Henning Rogge]

Am Dienstag 04 August 2009 12:56:52 schrieb Sebastian Harl:
> Hi,
>
> On Tue, Aug 04, 2009 at 12:07:17PM +0200, Henning Rogge wrote:
> > I don't think this patch will change the behaviour of dotdraw, because
> > the ip is checked after the accept() command. See line 266 to 270 in
> > olsrd_dot_draw.c
>
> Uh, I'm sorry - for some reason I seem to have misinterpreted the
> "accept" parameter ...
>
> My patch _does_ change the behavior of dotdraw - it lets the plugin bind
> to the specified IP only. However, instead of using the value of the
> "accept" parameter it should imho introduce a new parameter "listen" (or
> something like that). I'll provide an updated patch in a second.
I would be interesting in the use case for this behaviour. We have a unified 
"ACL" handling in the development tip, would be good to know if we have to 
change it...

> Sorry for the confusion!
no problem...

> Cheers,
> Sebastian
>
> PS:
> > Am Dienstag 04 August 2009 11:54:21 schrieb Holger Levsen:
> > > it seems this mail didnt make it to the list...
>
> olsr-dev seems to be subscriber-only or something like that. My previous
> E-mail had been accepted by lists.olsr.org but I've never received any
> notifications about being held back in some moderation queue or being
> dropped completely.

We had some problems with the http olsr.org server some time ago, but I though 
it would not matter for the mailing list. I'm not sure how the settings on 
this list are...

Henning
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.olsr.org/pipermail/olsr-dev/attachments/20090804/68497dee/attachment.sig>